Skip to content

8364004: Add an option for delayed crash tests #26453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jul 24, 2025

Pretty simple small addition to make -XX:ErrorHandlerTest work with an optional delay. This is a preparatory patch for some future planned refinements/additions to the error handler tests. It makes it possible to let the JVM warm up for a second or three, then to crash, in order to then observe an error log from a warmed-up JVM.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8364004: Add an option for delayed crash tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26453/head:pull/26453
$ git checkout pull/26453

Update a local copy of the PR:
$ git checkout pull/26453
$ git pull https://git.openjdk.org/jdk.git pull/26453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26453

View PR using the GUI difftool:
$ git pr show -t 26453

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26453.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 24, 2025

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8364004: Add an option for delayed crash tests 8364004: Add an option for delayed crash tests Jul 24, 2025
@openjdk
Copy link

openjdk bot commented Jul 24, 2025

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@tstuefe tstuefe marked this pull request as ready for review July 24, 2025 11:39
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 24, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 24, 2025

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I see the point of this being in the VM. First you are now going to trigger crashes in the WatcherThread instead of the main thread - not sure if that changes what you want to see. Second seems easier to just have a WhiteBox test that triggers different kinds of crashes after initialization.

If you want to trigger crashes at arbitrary times during initialization then I have no doubt you will find issues with crash reporting and it will be totally timing related and would make the test quite unstable.

@tstuefe
Copy link
Member Author

tstuefe commented Jul 25, 2025

@dholmes-ora You are right. I am closing this one in favor of the approach you suggested in JBS.

@tstuefe tstuefe closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants