Skip to content

Conversation

magicus
Copy link
Member

@magicus magicus commented Sep 19, 2025

I am trying to add --verify-excludes to all jtreg runs. This new flag will let jtreg catch (at least some) mistakes in problem lists. There are some technical hurdles remaining to add this option, but in the meantime I thought I could at least fix those issues I have found so far. This is not exhaustive, I am sure there are more issues that will be discovered, but these are at least real errors that can be fixed.

For reviewing, I recommend looking at the individual commits where I give a reason for each change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27391/head:pull/27391
$ git checkout pull/27391

Update a local copy of the PR:
$ git checkout pull/27391
$ git pull https://git.openjdk.org/jdk.git pull/27391/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27391

View PR using the GUI difftool:
$ git pr show -t 27391

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27391.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2025

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 19, 2025

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368094: Fix problem list errors

Reviewed-by: dholmes, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Sep 19, 2025

@magicus The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 19, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2025

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems very reasonable.

Thanks for cleaning this up.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 19, 2025
@dcubed-ojdk
Copy link
Member

Went thru the commits 1-by-1, all are very reasonable.

Thumbs up.

Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SA changes all look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review serviceability [email protected]
Development

Successfully merging this pull request may close these issues.

4 participants