-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8368094: Fix problem list errors #27391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems very reasonable.
Thanks for cleaning this up.
Went thru the commits 1-by-1, all are very reasonable. Thumbs up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SA changes all look good.
I am trying to add
--verify-excludes
to all jtreg runs. This new flag will let jtreg catch (at least some) mistakes in problem lists. There are some technical hurdles remaining to add this option, but in the meantime I thought I could at least fix those issues I have found so far. This is not exhaustive, I am sure there are more issues that will be discovered, but these are at least real errors that can be fixed.For reviewing, I recommend looking at the individual commits where I give a reason for each change.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27391/head:pull/27391
$ git checkout pull/27391
Update a local copy of the PR:
$ git checkout pull/27391
$ git pull https://git.openjdk.org/jdk.git pull/27391/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27391
View PR using the GUI difftool:
$ git pr show -t 27391
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27391.diff
Using Webrev
Link to Webrev Comment