8368102: Don't store macros in spec.gmk

[magicus]

We currently have three macros (as in "functions", not just simple strings) that are assigned in spec.gmk. This is in contrast with the rest of the values assigned in spec.gmk, and it is surprising and is forcing an odd syntax. Furthermore, these macros are named as constants, and not as we normally name functions/macros.

We should move them to normal .gmk code, and rename them.

The three macros are SET_SHARED_LIBRARY_ORIGIN, SET_EXECUTABLE_ORIGIN and SET_SHARED_LIBRARY_NAME.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8368102: Don't store macros in spec.gmk (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27394/head:pull/27394
$ git checkout pull/27394

Update a local copy of the PR:
$ git checkout pull/27394
$ git pull https://git.openjdk.org/jdk.git pull/27394/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27394

View PR using the GUI difftool:
$ git pr show -t 27394

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27394.diff

Using Webrev

Link to Webrev Comment

[magicus]

It is clear that this refactoring lends itself towards even more cleanups, but I'll save that for another day.

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5a259541)

[magicus]

Testing "builds" tier 1-5 in Oracle internal CI + COMPARE_BUILD with no differences.