Skip to content

8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 22, 2024

Hi all,

This pull request contains a backport of commit bc0379ea from the openjdk/jdk repository.

The commit being backported was authored by Phil Race on 25 May 2022 and was reviewed by Sergey Bylokhov and Prasanta Sadhukhan.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8275303 needs maintainer approval

Issue

  • JDK-8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/523/head:pull/523
$ git checkout pull/523

Update a local copy of the PR:
$ git checkout pull/523
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/523/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 523

View PR using the GUI difftool:
$ git pr show -t 523

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/523.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 22, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport bc0379ea1a22a2631b49ecd6a331352bec81c1c6 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver Jun 22, 2024
@openjdk
Copy link

openjdk bot commented Jun 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 22, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2024

@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2024

@mrserb This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Oct 12, 2024
@mrserb
Copy link
Member Author

mrserb commented Oct 17, 2024

/open

@openjdk openjdk bot reopened this Oct 17, 2024
@openjdk
Copy link

openjdk bot commented Oct 17, 2024

@mrserb This pull request is now open

@mrserb mrserb marked this pull request as ready for review October 21, 2024 16:02
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 21, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2024

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2024

@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Dec 12, 2024
@fthevenet
Copy link
Member

fthevenet commented May 20, 2025

Hi @mrserb.
I've been investigating an issue where an AWT app would cause an increase in CPU usage on Windows when the session is locked and the MS basic render driver is used (in this case because the app is used through a Remote Desktop session).
It turns out that JDK-8275303 is an effective workaround for such issues and I believe this should really be back-ported into JDK-8.
Would you mind re-opening this PR?
Thanks!

@mrserb
Copy link
Member Author

mrserb commented May 20, 2025

/open

@openjdk openjdk bot reopened this May 20, 2025
@openjdk
Copy link

openjdk bot commented May 20, 2025

@mrserb This pull request is now open

@fthevenet
Copy link
Member

Thanks @mrserb

@openjdk
Copy link

openjdk bot commented May 22, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mrserb
Copy link
Member Author

mrserb commented May 23, 2025

/approval request
Backport for parity with 8u391. This change disables D3D functionality when the "Microsoft Basic Render Driver" is detected, as it may cause rendering issues.

@openjdk
Copy link

openjdk bot commented May 23, 2025

@mrserb
8275303: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants