Skip to content

8340387: Update OS detection code to recognize Windows Server 2025 #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dimitryc
Copy link
Contributor

@dimitryc dimitryc commented May 21, 2025

Backport for parity with Oracle.

Almost clean backport after adjusting paths. The only conflict is in copyright years (in java_props_md.c), applied manually.

Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8340387 needs maintainer approval

Issue

  • JDK-8340387: Update OS detection code to recognize Windows Server 2025 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/655/head:pull/655
$ git checkout pull/655

Update a local copy of the PR:
$ git checkout pull/655
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/655/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 655

View PR using the GUI difftool:
$ git pr show -t 655

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/655.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 21, 2025

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 34cddfbedd20d5804cab8044fbc402564e98eb9c 8340387: Update OS detection code to recognize Windows Server 2025 May 21, 2025
@openjdk
Copy link

openjdk bot commented May 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 21, 2025
@mlbridge
Copy link

mlbridge bot commented May 21, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented May 22, 2025

⚠️ @dimitryc This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants