Skip to content

upgrade deamonset from v1alpha1 to v1beta1#2211

Merged
kruise-bot merged 6 commits into
openkruise:masterfrom
PersistentJZH:feat/upgrade-kruise-apis-to-v1beta1-phrase-3
Oct 30, 2025
Merged

upgrade deamonset from v1alpha1 to v1beta1#2211
kruise-bot merged 6 commits into
openkruise:masterfrom
PersistentJZH:feat/upgrade-kruise-apis-to-v1beta1-phrase-3

Conversation

@PersistentJZH

@PersistentJZH PersistentJZH commented Oct 20, 2025

Copy link
Copy Markdown
Member

Ⅰ. Describe what this PR does

upgrade deamenset apis from v1alpha1 to v1beta1

  • delete RollingUpdateType Surging
  • annotation daemonset.kruise.io/progressive-create-pod to scaleStrategy.partitionedScaling
  • status daemonSetHash to updateRevision
  • change Partition field type to IntOrString

Ⅱ. Does this pull request fix one issue?

#2122

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
kruise-bot requested review from veophi and zmberg October 20, 2025 13:48
@PersistentJZH
PersistentJZH force-pushed the feat/upgrade-kruise-apis-to-v1beta1-phrase-3 branch 2 times, most recently from c437c2e to 5ba6786 Compare October 21, 2025 08:39
@codecov

codecov Bot commented Oct 21, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.44186% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.75%. Comparing base (e8055e2) to head (3da3b96).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...k/daemonset/mutating/daemonset_mutating_handler.go 0.00% 32 Missing ⚠️
pkg/controller/daemonset/daemonset_controller.go 51.61% 12 Missing and 3 partials ⚠️
...nset/validating/daemonset_create_update_handler.go 73.21% 8 Missing and 7 partials ⚠️
...ontroller/daemonset/daemonset_predownload_image.go 0.00% 7 Missing ⚠️
pkg/controller/daemonset/daemonset_update.go 58.33% 3 Missing and 2 partials ⚠️
pkg/controller/daemonset/daemonset_util.go 77.77% 2 Missing and 2 partials ⚠️
...bhook/daemonset/validating/daemonset_validation.go 96.47% 2 Missing and 1 partial ⚠️
pkg/controller/daemonset/daemonset_history.go 83.33% 1 Missing ⚠️
pkg/webhook/daemonset/mutating/webhooks.go 0.00% 1 Missing ⚠️
pkg/webhook/daemonset/validating/webhooks.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2211      +/-   ##
==========================================
+ Coverage   45.14%   46.75%   +1.60%     
==========================================
  Files         318      320       +2     
  Lines       32665    26679    -5986     
==========================================
- Hits        14747    12473    -2274     
+ Misses      16479    12736    -3743     
- Partials     1439     1470      +31     
Flag Coverage Δ
unittests 46.75% <67.44%> (+1.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PersistentJZH
PersistentJZH force-pushed the feat/upgrade-kruise-apis-to-v1beta1-phrase-3 branch 3 times, most recently from c061063 to e5855e1 Compare October 21, 2025 15:38
Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>

update webhook logic

add omitempty to DaemonSetHash

add currentRevision cal logic

update CurrentRevision cal logic

optimize

fix e2e test
@PersistentJZH
PersistentJZH force-pushed the feat/upgrade-kruise-apis-to-v1beta1-phrase-3 branch 8 times, most recently from 14c621e to b78dd74 Compare October 22, 2025 13:41
@PersistentJZH PersistentJZH changed the title [WIP] upgrade deamonset from v1alpha1 to v1beta1 upgrade deamonset from v1alpha1 to v1beta1 Oct 22, 2025
Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>

remove debug log
@PersistentJZH
PersistentJZH force-pushed the feat/upgrade-kruise-apis-to-v1beta1-phrase-3 branch from b78dd74 to 887c3a1 Compare October 22, 2025 13:54
Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>
Comment thread apis/apps/v1alpha1/daemonset_conversion.go Outdated
Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>
@PersistentJZH
PersistentJZH force-pushed the feat/upgrade-kruise-apis-to-v1beta1-phrase-3 branch from 9292fed to 124d4cd Compare October 23, 2025 09:20
@zmberg

zmberg commented Oct 24, 2025

Copy link
Copy Markdown
Member

/lgtm

Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>
@kruise-bot kruise-bot removed the lgtm label Oct 29, 2025
@zmberg

zmberg commented Oct 29, 2025

Copy link
Copy Markdown
Member

/lgtm

@kruise-bot kruise-bot added lgtm and removed lgtm labels Oct 29, 2025
@PersistentJZH
PersistentJZH force-pushed the feat/upgrade-kruise-apis-to-v1beta1-phrase-3 branch from 1e8ff0e to 0ba8f97 Compare October 29, 2025 14:23
Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>

@furykerry furykerry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kruise-bot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
kruise-bot merged commit 3e86101 into openkruise:master Oct 30, 2025
59 checks passed
peng2x pushed a commit to peng2x/kruise that referenced this pull request Dec 19, 2025
* upgrade deamonset from v1alpha1 to v1beta1

Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>

update webhook logic

add omitempty to DaemonSetHash

add currentRevision cal logic

update CurrentRevision cal logic

optimize

fix e2e test

* change Partition to IntOrString

Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>

remove debug log

* remove CurrentRevision status

Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>

* do not remove ProgressiveCreatePod Annotation in convert to v1beta1

Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>

* change DaemonSetScaleStrategy cfg from Progressive to PartitionedScaling

Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>

* add more ut in daemonset validate webhook

Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>

---------

Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>
Signed-off-by: Peng Peng <ppbits3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants