Upgrade Cloneset from v1alpha1 to v1beta1#2225
Merged
furykerry merged 1 commit intoDec 26, 2025
Merged
Conversation
PersistentJZH
force-pushed
the
feat/upgrade-kruise-apis-to-v1beta1-phrase-5
branch
5 times, most recently
from
49cc5b7 to
1187cfd
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2225 +/- ##
==========================================
+ Coverage 47.89% 47.95% +0.06%
==========================================
Files 324 324
Lines 27520 27843 +323
==========================================
+ Hits 13181 13353 +172
- Misses 12844 12964 +120
- Partials 1495 1526 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PersistentJZH
force-pushed
the
feat/upgrade-kruise-apis-to-v1beta1-phrase-5
branch
5 times, most recently
from
0d3ead7 to
0844d5f
Compare
PersistentJZH
force-pushed
the
feat/upgrade-kruise-apis-to-v1beta1-phrase-5
branch
2 times, most recently
from
0ed533a to
9893d29
Compare
PersistentJZH
force-pushed
the
feat/upgrade-kruise-apis-to-v1beta1-phrase-5
branch
13 times, most recently
from
2f881ee to
9c25eab
Compare
PersistentJZH
force-pushed
the
feat/upgrade-kruise-apis-to-v1beta1-phrase-5
branch
6 times, most recently
from
a9e1d74 to
f644ced
Compare
PersistentJZH
force-pushed
the
feat/upgrade-kruise-apis-to-v1beta1-phrase-5
branch
from
f644ced to
a1567b5
Compare
furykerry
reviewed
Dec 3, 2025
| // Validate Parallelism (only supports integer, not percentage) | ||
| if obj.Spec.Parallelism != nil { | ||
| parallelism := obj.Spec.Parallelism | ||
| if parallelism.Type == 1 { // 1 is String type |
Member
There was a problem hiding this comment.
replace constant with intstr.String
| // Validate Parallelism (only supports integer, not percentage) | ||
| if obj.Spec.Parallelism != nil { | ||
| parallelism := obj.Spec.Parallelism | ||
| if parallelism.Type == 1 { // 1 is String type |
Member
There was a problem hiding this comment.
replace constant with intstr.String
PersistentJZH
force-pushed
the
feat/upgrade-kruise-apis-to-v1beta1-phrase-5
branch
from
1b7e8a4 to
a673d8a
Compare
Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com> - add OnDelete Strategy in v1bata1 CloneSet - add ProgressDeadlineSeconds in v1beta1 in cloneset - optimize CloneSetUpdateStrategy structure - transfer image preDownload related annotations to spec field - add image pre download field validate replace constant with intstr.String Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>
PersistentJZH
force-pushed
the
feat/upgrade-kruise-apis-to-v1beta1-phrase-5
branch
from
a673d8a to
6d9fc3b
Compare
PersistentJZH
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
upgrade Cloneset from v1alpha1 to v1beta1
change scaleStrategy.disablePVCReuse(default false) to scaleStrategy.enablePVCReuse(default false)
transfer annotation apps.kruise.io/cloneset-scaling-exclude-preparing-delete to scaleStrategy.excludePreparingDelete
optimize CloneSetUpdateStrategy structure
transfer image preDownload related annotations to spec field
Ⅱ. Does this pull request fix one issue?
#2122
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews