This repository was archived by the owner on Mar 26, 2022. It is now read-only.
Feature/apps 3013 markdown #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
solomontang
commented
Jun 23, 2021
•
solomontang
commented
- Add MarkdownPreview, MarkdownEditor, and MarkdownWrapper (styles) components
- adds react-markdown, remark-gfm, and rehype-highlight, to dependencies
- update material-ui to latest
solomontang
requested review from
UnsungHero97,
anzioka,
bergieboy and
giuliacampana
UnsungHero97
suggested changes
Jun 23, 2021
UnsungHero97
suggested changes
Jun 23, 2021
| "clsx": "~1.1.1", | ||
| "polished": "~4.1.0", | ||
| "process": "~0.11.10", |
There was a problem hiding this comment.
Is this the Node process package? Why does this need to be included? How big is the package?
There was a problem hiding this comment.
I see ... 🤔
Codecov Report
@@ Coverage Diff @@
## develop #1296 +/- ##
===========================================
+ Coverage 90.28% 90.39% +0.11%
===========================================
Files 125 128 +3
Lines 1420 1437 +17
Branches 385 388 +3
===========================================
+ Hits 1282 1299 +17
Misses 130 130
Partials 8 8
|
UnsungHero97
suggested changes
Jun 24, 2021
Comment on lines
96
to
98
| export { | ||
| MarkdownWrapper | ||
| }; |
There was a problem hiding this comment.
This should be the default export:
Suggested change
| export { | |
| MarkdownWrapper | |
| }; | |
| export default MarkdownWrapper; |
giuliacampana
previously approved these changes
Jun 24, 2021
anzioka
previously approved these changes
Jun 24, 2021
bergieboy
suggested changes
Jun 24, 2021
bergieboy
previously approved these changes
Jun 24, 2021
solomontang
dismissed stale reviews from bergieboy, anzioka, and giuliacampana
via
ad91121
UnsungHero97
approved these changes
Jun 24, 2021
anzioka
approved these changes
Jun 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.