Migrate project to modern python PEPs and uv#24
Merged
balsa-sarenac merged 12 commits intomainfrom Feb 25, 2026
Merged
Conversation
Switch to PEP 517/621 metadata so installs work with build isolation (including uv pip) and remove legacy setup.py-driven configuration.
Use uv pip for dependency installation so CI matches modern build isolation workflows and avoids legacy pip/setuptools bootstrapping.
Route install/uninstall operations through uv pip when available, while keeping pip for list/check. This avoids relying on deprecated pip behaviors and makes upgrades resilient to stdout changes.
Stop asserting pip-specific uninstall/install output so tests remain valid when installs are performed via uv pip.
Use python -m build to generate test wheels so fixture generation matches modern, isolated build workflows.
Add a uv-first dev install snippet so contributors use the same modern installer behavior as CI and production.
Preserve symlinks when cloning venvs for blue/green upgrades and treat failed upgrade subprocess output as empty so error paths don't crash with TypeError.
Use uv pip install/uninstall -p <python> so installs target the intended interpreter even when the venv is not activated.
Avoid untracked upgrade/_version.py after editable installs.
sale3
reviewed
Feb 24, 2026
sale3
approved these changes
Feb 24, 2026
CI previously used `uv pip install --system` because no virtualenv existed, which installs into the runner interpreter environment. Create and target a per-job venv instead to keep dependency state isolated and reduce cross-runner contamination risk (especially on self-hosted runners).
The function already treats a missing version as valid input; updating the signature prevents misleading type assumptions and makes intent explicit.
balsa-sarenac
force-pushed
the
chore/modernize-uv-pep517
branch
from
e9fecf2 to
39e0853
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.