Allow rendering of feature when download of icon failed #3128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good to me. See https://github.com/elemoine/ol3/commit/a4d51fbbb0e63070aa7d89ddddcc716ab75fa01e for unit tests. Please add this commit to your branch if you agree with it. |
|
Thks you very much for the tests @elemoine, I add them |
elemoine
pushed a commit
that referenced
this pull request
Jan 21, 2015
Allow rendering of feature when download of icon failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a feature is not rendered when the download of icon, defined in an image style, failed (bad link, offline mode).
That makes sense only for
ol.geom.Pointandol.geom.MultiPoint. The others types of geometry don't use the image style, so this PR allows rendering of feature when the download of an icon failed.Any opinions?