Skip to content

Move the icon style color to its own example #4642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2016

Conversation

alexbrault
Copy link
Contributor

Per discussion on #4457, move the example of the icon colour to its own example and restore the previous icon example

@fredj fredj added this to the v3.13.0 milestone Jan 12, 2016
@fredj
Copy link
Member

fredj commented Jan 13, 2016

@alexbrault Can you please rebase your code on master?

@fredj
Copy link
Member

fredj commented Jan 13, 2016

And I propose to remove all the popup code in this example

docs: >
Example assigning a custom color to an icon. The features in this examples are all using the same image with the different colors coming from the javascript file
tags: "vector, style, icon, marker"
resources:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove all the resources (related to the popup)

@fredj
Copy link
Member

fredj commented Jan 19, 2016

Thanks @alexbrault

fredj added a commit that referenced this pull request Jan 19, 2016
Move the icon style color to its own example
@fredj fredj merged commit 4dbc4c5 into openlayers:master Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants