Add color option to ol.style.Icon #4457
Conversation
|
@ahocevar, I ended up multiplying pixel values instead of replacing white with the colour because the latter left undesired artifacts in the majority of cases (e.g. anything with antialiasing) |
alexbrault
force-pushed
the
colour-icon
branch
from
12e2a14 to
afe11b3
Compare
|
Thanks for this pull request @alexbrault. Great enhancement! I'll review it within the next few days. |
| @@ -492,6 +516,7 @@ ol.style.IconImage_.prototype.handleImageLoad_ = function() { | |||
| this.imageState_ = ol.style.ImageState.LOADED; | |||
| this.size_ = [this.image_.width, this.image_.height]; | |||
| this.unlistenImage_(); | |||
| this.replaceColor_(); | |||
There was a problem hiding this comment.
Applying the color will only work if the image is not tainted.
It should be moved after determineTainting().
alexbrault
force-pushed
the
colour-icon
branch
4 times, most recently
from
06a5230 to
28633e4
Compare
| @@ -6004,6 +6004,7 @@ olx.style.FillOptions.prototype.color; | |||
| * anchorOrigin: (ol.style.IconOrigin|undefined), | |||
| * anchorXUnits: (ol.style.IconAnchorUnits|undefined), | |||
| * anchorYUnits: (ol.style.IconAnchorUnits|undefined), | |||
| * color: (ol.Color|undefined), | |||
There was a problem hiding this comment.
Would be nice to also accept a string here.
There was a problem hiding this comment.
I forget what my reasoning for omitting this was, but yes, it should
alexbrault
force-pushed
the
colour-icon
branch
from
28633e4 to
c80ff96
Compare
alexbrault
force-pushed
the
colour-icon
branch
from
c80ff96 to
3f16b34
Compare
|
This looks great @alexbrault. It looks like we do not have a CLA on file from you yet. Can you please submit one so we can merge this? |
Thanks @alexbrault for openlayers/openlayers#4457 and any future contributions you can make.
Add color option to ol.style.Icon
| @@ -23,6 +23,7 @@ var iconStyle = new ol.style.Style({ | |||
| anchor: [0.5, 46], | |||
| anchorXUnits: 'fraction', | |||
| anchorYUnits: 'pixels', | |||
| color: '#8959A8', | |||
There was a problem hiding this comment.
I think it would be nicer to have a dedicated example that shows what this option should be used for. We have a bad tendency to continue modifying examples that started out simple until they become overly complex (or just ugly). And I think this particular example looked nicer before the color option was added (same goes for opacity).
There was a problem hiding this comment.
Good point. I'll submit a PR to fork the example
This PR adds a color option to tint an ol.style.Icon.
See https://groups.google.com/forum/#!topic/ol3-dev/vPK4ygQHaqo