Skip to content

Fix autoPan in examples with ol.Overlay on hover #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2015

Conversation

tsauerwein
Copy link
Member

#3256 enabled autoPan by default which made the map pan uncontrollable in examples where an overlay is shown on mouse hover.

This PR disables autoPan for the example measure and tileutfgrid.

To avoid that the map is panned when showing
overlays on hover.
@elemoine
Copy link
Member

LGTM. Thanks @tsauerwein.

tsauerwein pushed a commit that referenced this pull request Feb 24, 2015
Fix autoPan in examples with ol.Overlay on hover
@tsauerwein tsauerwein merged commit 7a5ad33 into openlayers:master Feb 24, 2015
@tsauerwein tsauerwein deleted the fix-example-autoPan branch February 24, 2015 08:48
@elemoine
Copy link
Member

ol.Overlay is a generic tool that can be used for many different things. So @fredj and I are wondering whether it'd be better to have autoPan default to false. @tsauerwein, any opinion about this?

@tsauerwein
Copy link
Member Author

Yes, I think that would make sense. For a popup it's reasonable to have autoPan enabled by default, but ol.Overlay is really to generic.

@elemoine
Copy link
Member

Yes, I think that would make sense. For a popup it's reasonable to have autoPan enabled by default, but ol.Overlay is really to generic.

Yep. I'll create a PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants