Skip to content

Add ol.source.ImageArcGISRest #3880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 20, 2016

Conversation

llambanna
Copy link
Contributor

ol.source.ImageArcGISRest is added so a single image can be retrieved
which is required when labelling is applied to the underlying map
service.
it's based on the approach used in ol.source.ImageWMS and ol.source.TileArcGISRest

usage:

var layer = new ol.layer.Image({
  source: new ol.source.ImageArcGISRest({
    url: "http://sampleserver1.arcgisonline.com/ArcGIS/rest/services/Specialty/ESRI_StateCityHighway_USA/MapServer",
  })
});

ol.source.ImageArcGISRest is added so a single image can be retrieved
which is required when labelling is applied to the underlying map
service.
it's based on the approach used in ol.source.ImageWMS
@ahocevar
Copy link
Member

ahocevar commented Oct 8, 2015

This branch has conflicts. Closing due to lack of activity. @llambanna, please reopen when you get to working on this again.

@ahocevar
Copy link
Member

Thanks for your solid work on this @llambanna. I have reopened the pull request because there seems to be demand for it. Any chance you could update this branch so it has no conflicts any more, and remove the use of goog.isDef, goog.isNull, goog.string.endsWith and goog.object?

@devdattaT
Copy link

@llambanna , @ahocevar Can I send a PR after conflict resolution and other issues, so that we can get this working?

@llambanna
Copy link
Contributor Author

Yep, I just need to find time to tidy it up, next week with a bit of luck.

On Fri, 15 Apr 2016, 10:30 p.m. Devdatta Tengshe, [email protected]
wrote:

@llambanna https://github.com/llambanna , @ahocevar
https://github.com/ahocevar Can I send a PR after conflict resolution
and other issues, so that we can get this working?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#3880 (comment)

@llambanna
Copy link
Contributor Author

@ahocevar as you can see from my commits, i've updated from master, removed the goog usages and updated so it passes the build and tests.

@ahocevar
Copy link
Member

Thanks a lot @llambanna.

* @type {ol.Collection.<ol.Feature>|undefined}
* @api
*/
olx.interaction.SelectOptions.prototype.features;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was accidentally removed?

@ahocevar
Copy link
Member

ahocevar commented Apr 19, 2016

Looks very good @llambanna. Do you think you are able to add back olx.interaction.SelectOptions.prototype.features to externs/olx.js? This is the only think that keeps me from merging immediately.

@llambanna
Copy link
Contributor Author

@ahocevar i've added that back in as well as an example

@ahocevar
Copy link
Member

This is truly awesome @llambanna. Thank you so much for this contribution, and sorry for having closed this without giving it the attention it deserved.

@ahocevar ahocevar merged commit 18a29ea into openlayers:master Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants