-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add ol.source.ImageArcGISRest #3880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ol.source.ImageArcGISRest #3880
Conversation
ol.source.ImageArcGISRest is added so a single image can be retrieved which is required when labelling is applied to the underlying map service. it's based on the approach used in ol.source.ImageWMS
This branch has conflicts. Closing due to lack of activity. @llambanna, please reopen when you get to working on this again. |
Thanks for your solid work on this @llambanna. I have reopened the pull request because there seems to be demand for it. Any chance you could update this branch so it has no conflicts any more, and remove the use of |
@llambanna , @ahocevar Can I send a PR after conflict resolution and other issues, so that we can get this working? |
Yep, I just need to find time to tidy it up, next week with a bit of luck. On Fri, 15 Apr 2016, 10:30 p.m. Devdatta Tengshe, [email protected]
|
…ource_imagearcgisrest # Conflicts: # externs/olx.js
changing so js passes lint checks
@ahocevar as you can see from my commits, i've updated from master, removed the goog usages and updated so it passes the build and tests. |
Thanks a lot @llambanna. |
* @type {ol.Collection.<ol.Feature>|undefined} | ||
* @api | ||
*/ | ||
olx.interaction.SelectOptions.prototype.features; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was accidentally removed?
Looks very good @llambanna. Do you think you are able to add back |
@ahocevar i've added that back in as well as an example |
This is truly awesome @llambanna. Thank you so much for this contribution, and sorry for having closed this without giving it the attention it deserved. |
ol.source.ImageArcGISRest is added so a single image can be retrieved
which is required when labelling is applied to the underlying map
service.
it's based on the approach used in ol.source.ImageWMS and ol.source.TileArcGISRest
usage: