Skip to content

Fix rendering of mocha's special characters on travis #4377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix rendering of mocha's special characters on travis #4377

wants to merge 1 commit into from

Conversation

marcjansen
Copy link
Member

This PR suggests to use a recent version of mocha-phantomjs which fixes the output of the testsuite on travis.

The tasks/test.js had to be adjusted to directly use the mocha-phantomjs binary.

Before:

ol3-tests-on-travis-before

After:

ol3-tests-on-travis-after

Please review.

@marcjansen marcjansen changed the title WIP test rendering output Fix rendering of mocha's special characters on travis Nov 5, 2015
@marcjansen
Copy link
Member Author

Thanks for any review.

@ahocevar
Copy link
Member

ahocevar commented Nov 5, 2015

Wondering about why you switched back to mocha-phantomjs after 98c9b0e. From the package description:

Since 4.0, the phantomjs code now is in mocha-phantomjs-core. If you need full control over which phantomjs version to use and where to get it, or want to use it more programatically like a build system plugin, please use that package directly. This project is a node.js CLI around it.

So I guess there should be a better way than spawning a process, i.e. use mocha-phantomjs-core "more programmatically" somehow. Have you investigated this a bit maybe?

@ahocevar
Copy link
Member

ahocevar commented Nov 5, 2015

The reason why I'm asking is because this looks like a character encoding issue, something like UTF-8 not being used by Travis.

@marcjansen
Copy link
Member Author

I didn't check the 'more programmatic' approach. That would probably be advisable, but I fear my node-foo (and time) are too limited to give this a shot right now. Maybe @tschaub can weigh in about how to proceed, if you don't mind.

@marcjansen
Copy link
Member Author

Looking at https://github.com/nathanboktae/mocha-phantomjs-core/blob/master/README.md it looks both interesting and doable. If you prefer a solution based on the core package, I wouldn't mind if we close this issue, @ahocevar. I am just not sure if I can come up with something quickly.

@ahocevar
Copy link
Member

ahocevar commented Nov 5, 2015

Not sure if I find time, but maybe I can give it a crack this weekend.

@ahocevar
Copy link
Member

ahocevar commented Nov 6, 2015

@marcjansen Please see #4390 for a more programmatic solution.

@marcjansen
Copy link
Member Author

It doesn't get better than #4390. Thanks.

@marcjansen marcjansen closed this Nov 7, 2015
@marcjansen marcjansen deleted the test-output-mess branch November 9, 2015 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants