Skip to content

Fix a bug in openmc.data.combine_distributions #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

GuySten
Copy link
Contributor

@GuySten GuySten commented Jun 16, 2025

Description

This pr change the implementation of combine_distributions to support combination of any Univariate distributions with specified probabilities.

The new implementation knows to combine analytically discrete and normal distributions.

Fixes #3105

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten GuySten marked this pull request as ready for review June 16, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

probs arg ignored if openmc.stats.Normal passed to openmc.stats.combine_distributions
1 participant