Designated period and user class exceptions

[mplsmitch]

---

---

CDS Pull Request

Explain pull request

The current definition of designated_period_except is limited to values named in designated_period. That makes it difficult to define rules that use exceptions with standard time spans, for example: No Parking Except Sundays. This extends the definition of designated_period_except to include all time spans in addition to any named in designated_period. For example, If days_of_week is sun, the rule does not apply on Sundays.

This also adds a new field: user_classes_except that defines exceptions to user classes. When set, the rule applies only to those that do not match any of the user classes listed in the user_classes_except array.

Additional info and discussion can be found in #136 and #117

Is this a breaking change

• No, not breaking

Impacted Spec

Which API(s) will this pull request impact?

• Curbs

Additional context

Add any other context or screenshots about the feature request here.

[schnuerle]

From the WG discussion:

• designated_period string field
• Add a new designated_period_except boolean field
• user class exception in there now for permits, in there now, non breaking
• Followup with Laurant to see if this meets his needs - not sure how to do the two layers of exceptions, possibly for breaking
• Can keep these names as is, and keep it non breaking, but note to change names in 2.0 later
• Populus is already using this change, basically as laid out. "Exception schedule" field so the whole rule does not apply at this time

New PR here. @jiffyclub and @LaurentG-AMD what do you think of this as the current 1.1 solution? Matt, is this how you do it, or do you just have 1 field that flags the whole rule as an exception schedule?

Anything you would change, either the field names or description?

[jiffyclub]

This is how we do it, we set designated_period_except=True on any time span at which the rule does not apply.