docs: define max_stay_unit and no_return_unit#72
Merged
schnuerle merged 5 commits intoopenmobilityfoundation:release-1.0.0from Apr 14, 2022
Merged
Conversation
Author
|
@schnuerle , does this still require discussion? |
schnuerle
reviewed
Apr 13, 2022
Member
|
Zane I'm considering adding this in the 1.0 release since it's consistent with other parts of CDS and is a relatively minor change. Can you resolve the conflicts today that have come up? I can't because I don't have edit access to your repo for this PR. Do you feel this is ready for 1.0, or do you think it should wait for 2.0 (since it would be a breaking change)? |
added 2 commits
April 13, 2022 16:59
…ition # Conflicts: # curbs/README.md
schnuerle
reviewed
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain pull request
Define a default for Rule.max_stay and Rule.no_return. Define Rule.max_stay_unit and Rule.no_return_unit to decouple standard from relying on minutes.
Is this a breaking change
Impacted Spec
Which API(s) will this pull request impact?
CurbsAdditional context
Add any other context or screenshots about the feature request here.
Part of this discussion comment.