Skip to content

Fetch JWKS and token endpoint via internal API URL - #17

Merged
ravikiranvm merged 2 commits into
mainfrom
ops-4866
Sep 22, 2026
Merged

ravikiranvm merged 2 commits into
mainfrom
ops-4866

Conversation

@ravikiranvm

Copy link
Copy Markdown
Contributor

Fixes OPS-4866

Copilot AI lite review requested due to automatic review settings September 22, 2026 12:59
@linear

linear Bot commented Sep 22, 2026

Copy link
Copy Markdown

OPS-4866

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Update both architecture examples to use OPENOPS_API_URL consistently with the runtime behavior.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Low severity

Open (1)
What changed in this PR

Updates OAuth endpoint resolution to use the internal API URL while retaining the public issuer for identity.

Changes:

  • Routes JWKS and token exchange through OPENOPS_API_URL.
  • Updates tests and deployment documentation.
  • Clarifies issuer and internal API responsibilities.
File Summary
tests/​unit/​test_config.py Verifies internal API endpoint derivation.
README.md Updates configuration and Docker networking guidance.
openops_mcp/​config.py Uses the API URL for OAuth endpoints.
openops_mcp/​auth/​oauth.py Clarifies internal JWKS retrieval.
docs/​architecture.md Updates OAuth architecture guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/architecture.md Resolved
@ravikiranvm
ravikiranvm merged commit 1c45ccf into main Sep 22, 2026
8 checks passed
@ravikiranvm
ravikiranvm deleted the ops-4866 branch September 22, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants