Skip to content

Solarfactors notebook #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

echedey-ls
Copy link
Contributor

@echedey-ls echedey-ls commented Jul 13, 2024

See #8

@echedey-ls
Copy link
Contributor Author

Let me know what you think @kandersolar, and if I've missed doing something.

@kandersolar
Copy link
Member

Thanks @echedey-ls! The figure below doesn't look great by default, but I think it's okay since the figure is interactive (zoom, hover, etc).

image

Is there anything else you want to do before merging? It is fine with me as-is.

@echedey-ls
Copy link
Contributor Author

Honestly, I wasn't able to make sphinx build the webpage, only the notebook. But if you can make it work, that's fine then.

Is there anything else you want to do before merging? It is fine with me as-is.

Nothing else from my side, no.

@echedey-ls echedey-ls marked this pull request as ready for review July 15, 2024 16:17
@kandersolar kandersolar merged commit 01a2b19 into openpvtools:main Jul 22, 2024
@kandersolar
Copy link
Member

Thanks @echedey-ls!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants