improve: supported the link response header #1459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Nginx/1.13.10. The `Link` header was treated as a common header and equipped a shortcut pointer (`r->headers_out.link`). Currently this module doesn't follow this behavior. Consequently, `Link` header set by this module (e.g. in `header_filter_by_lua*`) cannot be referenced from `r->headers_out.link`. It may cause some inconsistent problems. For instance, the HTTP/2 server push preload, see openresty#1458 for details. This Commit placed the Link header inside `ngx_http_lua_set_handlers[]`.
|
This seems like a duplicate of #1389 ? Although being on mobile right now, I have not double checked. |
|
@thibaultcha |
|
@thibaultcha I'm going to close this PR. |
|
The other PR has been lacking tests for a while now... Maybe yours could add them? |
|
@thibaultcha |
|
I meant into your own PR (this one). Another option would be a new PR with the existing commit and your own adding the tests. |
|
@thibaultcha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Nginx/1.13.10. The
Linkheader was treated as a common header andequipped with a shortcut pointer (
r->headers_out.link). Currently this module doesn'tfollow this behavior. Consequently,
Linkheader set by this module(e.g. in
header_filter_by_lua*) cannot be referenced fromr->headers_out.link. It may cause some inconsistent problems. For instance,the HTTP/2 server push preload option, see #1458 for details.
This Commit placed the Link header inside
ngx_http_lua_set_handlers[].I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.