Skip to content

feature: added new API bind tcpsock:bind. #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

zhuizhuhaomeng
Copy link
Contributor

Co-authored-by: doujiang24 [email protected]
Co-authored-by: lijunlong [email protected]

I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.

Co-authored-by: doujiang24 <[email protected]>
Co-authored-by: lijunlong <[email protected]>
@zhuizhuhaomeng
Copy link
Contributor Author

This PR rebase #72 to the master and fixed test cases error.

@zhuizhuhaomeng zhuizhuhaomeng changed the title feature: added new API bind. feature: added new API bind tcpsock:bind. Jul 8, 2022
Copy link
Member

@doujiang24 doujiang24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, LGTM.

------------
**syntax:** *ok, err = tcpsock:bind(address)*

**context:** *rewrite_by_lua&#42;, access_by_lua&#42;, content_by_lua&#42;, ngx.timer.&#42;, ssl_certificate_by_lua&#42;*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ssl_session_fetch_by_lua*, ssl_client_hello_by_lua*.

@mergify
Copy link

mergify bot commented Jul 13, 2022

This pull request is now in conflict :(

@mergify mergify bot added the conflict label Jul 13, 2022
@zhuizhuhaomeng
Copy link
Contributor Author

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants