Note concerning ngx.location.capture buffering all subrequest c… #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3120,6 +3120,7 @@ Nginx's subrequests provide a powerful way to make non-blocking internal request | |||
| `ngx_postgres`, `ngx_drizzle`, and even ngx_lua itself and etc etc etc. | |||
|
|
|||
| Also note that subrequests just mimic the HTTP interface but there is *no* extra HTTP/TCP traffic *nor* IPC involved. Everything works internally, efficiently, on the C level. | |||
| This also mean that subrequests are fully performed and buffered before being returned to Lua: making a subrequest call to a location that can return or stream a large amount of data (including by using sendfile) is probably a bad idea. | |||
There was a problem hiding this comment.
Hmm, I'm afraid there is no causal relationship here. The real reason behind the always-fully-buffering behaviour is that this API just does not support streaming.
agentzh
added a commit
that referenced
this pull request
Dec 11, 2015
….capture* API. thanks cmaion for the original patch in #607.
|
@cmaion Just committed a different patch to git master to address this concern. Thanks for the patch all the same. |
|
Thanks @agentzh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#603