Conversation
|
It's far from perfect, but I've managed to do dark mode / light mode switching. I removed the "Fork me on Github" in favor of the theme switch. If you'll consider anything from my branch useful, please use it. I don't want to break any existing code, but this version works fine. Demo at https://openscad.tekk.eu |
|
I'm highly in favor of this feature! But to make it less controversial, I think it would make sense to put the dark/light mode toggle in the settings menu (cog on the lower-right) instead of replacing the fork me banner. |
|
@ochafik - what are your initial thoughts on the approach this PR takes? Is there anything you would want done differently? |
|
I'm not going to speak for @ochafik but replacing the icon without any hint or explanation seems like a red flag. What's the default behavior? Ideally it should default to the normal user setting and allow to change it from there. |
|
@tekk https://openscad.tekk.eu/ this is awesome , but unfortunately including bosl2 wont work |
|
Hello. I have made a new pull based on @tekk work. I'm unsure how to actually propose the patches on this one. I hope i'm not breaking some etiquette, to respect the original author i've added him as a co-author. |
|
I'm not a lawyer, but considering the code base itself is GPL2+, PRs would be expected to be GPL2+ if not explicitly stated otherwise. So from that, it should be fine to base more changes on top. |
|
Allright thanks @t-paul. |
Implemented dark mode / light mode switching.