Skip to content

Dark mode switching#128

Open
tekk wants to merge 5 commits intoopenscad:mainfrom
tekk:dark-mode-switching
Open

Dark mode switching#128
tekk wants to merge 5 commits intoopenscad:mainfrom
tekk:dark-mode-switching

Conversation

@tekk
Copy link

@tekk tekk commented Oct 15, 2025

Implemented dark mode / light mode switching.

@tekk
Copy link
Author

tekk commented Oct 15, 2025

It's far from perfect, but I've managed to do dark mode / light mode switching. I removed the "Fork me on Github" in favor of the theme switch. If you'll consider anything from my branch useful, please use it. I don't want to break any existing code, but this version works fine. Demo at https://openscad.tekk.eu

@joeskeen
Copy link

I'm highly in favor of this feature!

But to make it less controversial, I think it would make sense to put the dark/light mode toggle in the settings menu (cog on the lower-right) instead of replacing the fork me banner.

@joeskeen joeskeen mentioned this pull request Jan 18, 2026
@joeskeen
Copy link

@ochafik - what are your initial thoughts on the approach this PR takes? Is there anything you would want done differently?

@t-paul
Copy link
Member

t-paul commented Jan 18, 2026

I'm not going to speak for @ochafik but replacing the icon without any hint or explanation seems like a red flag.

What's the default behavior? Ideally it should default to the normal user setting and allow to change it from there.

@jonasfrey
Copy link

@tekk https://openscad.tekk.eu/ this is awesome , but unfortunately including bosl2 wont work
include <BOSL2/std.scad>

@luckcolors
Copy link

Hello.

I have made a new pull based on @tekk work. I'm unsure how to actually propose the patches on this one.
Given i have restored the favicons, and made chages as little as possible as to make this possible easier and faster to get approved.

I hope i'm not breaking some etiquette, to respect the original author i've added him as a co-author.
Thanks.

@t-paul
Copy link
Member

t-paul commented Feb 11, 2026

I'm not a lawyer, but considering the code base itself is GPL2+, PRs would be expected to be GPL2+ if not explicitly stated otherwise. So from that, it should be fine to base more changes on top.
I guess just create the new PR against this repo, maybe @tekk sees the notification and adds comments too.

@luckcolors
Copy link

Allright thanks @t-paul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants