Support side-by-side installation of Qt4 and Qt5 builds #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nim65s
pushed a commit
to nim65s/gepetto-viewer-corba
that referenced
this pull request
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose this patch to support side-by-side installation of osgQt built against both Qt4 and Qt5. This would greatly simplify the packaging task downstream in various Linux distros, since not all projects have made the transition to Qt5 and hence both osgQt-qt4 and osgQt-qt5 are needed. (And the same situation might occur again if and when Qt6 is released).
Having support upstream would be advantageous instead of every distro hacking in their own solution.
This proposed patch keeps the osgQt name for the Qt4 build, but adds a 5 (i.e. osgQt5) for the Qt5 build. This is consistent with Qt (i.e. libQtCore -> Qt4, libQt5Core -> Qt5). It adds qt5 to the name of the example executables as appropriate.