[META] IngestService needs xContentRegistry for parametized models.

[brianf-aws]

Please describe the end goal of this project

Currently search pipelines is able to pass xContentRegistry

OpenSearch/server/src/main/java/org/opensearch/node/Node.java

Lines 1311 to 1320 in 35c366d

	final SearchPipelineService searchPipelineService = new SearchPipelineService(
	clusterService,
	threadPool,
	this.environment,
	scriptService,
	analysisModule.getAnalysisRegistry(),
	xContentRegistry,
	namedWriteableRegistry,
	pluginsService.filterPlugins(SearchPipelinePlugin.class),
	client

This allows the search response/request processors to handle customized parametrized local models.

However Ingest processors have no way of having this field meaning you can not ingest documents using a model that requires parametrized arguments such as local asymmetric embedding model . The fix would be to have a contentRegistry within the ingestService class

OpenSearch/server/src/main/java/org/opensearch/node/Node.java

Lines 937 to 946 in 35c366d

	final IngestService ingestService = new IngestService(
	clusterService,
	threadPool,
	this.environment,
	scriptService,
	analysisModule.getAnalysisRegistry(),
	pluginsService.filterPlugins(IngestPlugin.class),
	client,
	indicesService
	);

as well as configuring the Ingest processor Parameters class to have a xcontentRegistry just how the search response/request processors have the field.

Supporting References

Taken from my comment

opensearch-project/ml-commons#3276 (comment)

Action Items in this change

opensearch-project/ml-commons#3276 (comment)

Issues

• [] [BUG] MLInferenceIngestProcessor has xContentRegistry as null  ml-commons#3276

Related component

Plugins

[sandeshkr419]

@gaobinlong Hey, what do you think of this?

[gaobinlong]

@gaobinlong Hey, what do you think of this?

After checking the original issue in ml-commons plugin and the code, I think it makes sense that we add a construction parameter xContentRegistry to IngestService.

[dblock]

[Catch All Triage - 1, 2, 3, 4, 5, 6]