Skip to content

Unset discovery nodes for every transport node actions request #17682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 22, 2025

Conversation

gargmanik13
Copy link
Contributor

@gargmanik13 gargmanik13 commented Mar 25, 2025

Description

Continuation to #15131, unsetting discovery nodes for every request before sending transport request to individual nodes.
Removed includeDiscoveryNodes field from BaseNodesRequest.

Related Issues

Resolves #17008

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added >breaking Identifies a breaking change. Cluster Manager enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0 labels Mar 25, 2025
Copy link
Contributor

❕ Gradle check result for abf03ec: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.classMethod
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 72.60%. Comparing base (96481cc) to head (776ebcc).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...ices/dangling/list/ListDanglingIndicesRequest.java 0.00% 2 Missing ⚠️
...luster/node/hotthreads/NodesHotThreadsRequest.java 0.00% 1 Missing ⚠️
.../node/reload/NodesReloadSecureSettingsRequest.java 50.00% 1 Missing ⚠️
...on/admin/cluster/node/usage/NodesUsageRequest.java 0.00% 1 Missing ⚠️
...napshots/status/TransportNodesSnapshotsStatus.java 0.00% 1 Missing ⚠️
...arch/action/admin/cluster/wlm/WlmStatsRequest.java 50.00% 1 Missing ⚠️
...ndices/dangling/find/FindDanglingIndexRequest.java 0.00% 1 Missing ⚠️
...ch/gateway/TransportNodesListGatewayMetaState.java 0.00% 1 Missing ⚠️
...y/TransportNodesListGatewayStartedShardsBatch.java 0.00% 1 Missing ⚠️
...es/store/TransportNodesListShardStoreMetadata.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17682      +/-   ##
============================================
+ Coverage     72.59%   72.60%   +0.01%     
+ Complexity    67172    67128      -44     
============================================
  Files          5478     5478              
  Lines        310125   310113      -12     
  Branches      45080    45079       -1     
============================================
+ Hits         225135   225159      +24     
+ Misses        66676    66582      -94     
- Partials      18314    18372      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

❌ Gradle check result for 776ebcc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gargmanik13
Copy link
Contributor Author

❌ Gradle check result for 776ebcc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Test Result (1 failure / +1)
org.opensearch.versioning.ConcurrentSeqNoVersioningIT.testSeqNoCASLinearizability

Flaky Test: #17271

Copy link
Contributor

❌ Gradle check result for 776ebcc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 776ebcc: SUCCESS

@shwetathareja shwetathareja merged commit 2bd3e3d into opensearch-project:main Apr 22, 2025
30 of 31 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cluster Manager Project Board Apr 22, 2025
@opensearch-trigger-bot
Copy link
Contributor

The backport to 3.0 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-3.0 3.0
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-3.0
# Create a new branch
git switch --create backport/backport-17682-to-3.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2bd3e3dcc9a97f8cfd2065b09a125079a2d35f3c
# Push it to GitHub
git push --set-upstream origin backport/backport-17682-to-3.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-3.0

Then, create a pull request where the base branch is 3.0 and the compare/head branch is backport/backport-17682-to-3.0.

gargmanik13 added a commit to gargmanik13/OpenSearch that referenced this pull request Apr 23, 2025
…earch-project#17682)

* Removed includeDiscoveryNodes from BaseNodesRequest

Signed-off-by: Manik Garg <[email protected]>
(cherry picked from commit 2bd3e3d)
gargmanik13 added a commit to gargmanik13/OpenSearch that referenced this pull request Apr 23, 2025
…earch-project#17682)

* Removed includeDiscoveryNodes from BaseNodesRequest

(cherry picked from commit 2bd3e3d)
Signed-off-by: Manik Garg <[email protected]>
andrross pushed a commit that referenced this pull request Apr 23, 2025
… (#18047)

* Removed includeDiscoveryNodes from BaseNodesRequest

(cherry picked from commit 2bd3e3d)
Signed-off-by: Manik Garg <[email protected]>
x-INFiN1TY-x pushed a commit to x-INFiN1TY-x/OpenSearch_Local that referenced this pull request Apr 24, 2025
…earch-project#17682)

* Removed includeDiscoveryNodes from BaseNodesRequest

Signed-off-by: Manik Garg <[email protected]>
Signed-off-by: Tanishq Ranjan <[email protected]>
@gargmanik13 gargmanik13 deleted the dev_manik branch April 28, 2025 06:31
gargmanik13 added a commit to gargmanik13/OpenSearch that referenced this pull request Apr 29, 2025
andrross pushed a commit that referenced this pull request Apr 29, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 29, 2025
Signed-off-by: Manik Garg <[email protected]>
(cherry picked from commit d706593)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Apr 29, 2025
(cherry picked from commit d706593)

Signed-off-by: Manik Garg <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi pushed a commit to prudhvigodithi/OpenSearch that referenced this pull request May 6, 2025
…earch-project#17682) (opensearch-project#18047)

* Removed includeDiscoveryNodes from BaseNodesRequest

(cherry picked from commit 2bd3e3d)
Signed-off-by: Manik Garg <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]>
prudhvigodithi pushed a commit to prudhvigodithi/OpenSearch that referenced this pull request May 6, 2025
…rch-project#18140) (opensearch-project#18141)

(cherry picked from commit d706593)

Signed-off-by: Manik Garg <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Prudhvi Godithi <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…earch-project#17682)

* Removed includeDiscoveryNodes from BaseNodesRequest

Signed-off-by: Manik Garg <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…earch-project#17682)

* Removed includeDiscoveryNodes from BaseNodesRequest

Signed-off-by: Manik Garg <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 3.0 backport-failed >breaking Identifies a breaking change. Cluster Manager enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Feature Request] Unset discoveryNodes object from BaseNodeRequest sent over Transport
5 participants