-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Unset discovery nodes for every transport node actions request #17682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Manik Garg <[email protected]>
❕ Gradle check result for abf03ec: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17682 +/- ##
============================================
+ Coverage 72.59% 72.60% +0.01%
+ Complexity 67172 67128 -44
============================================
Files 5478 5478
Lines 310125 310113 -12
Branches 45080 45079 -1
============================================
+ Hits 225135 225159 +24
+ Misses 66676 66582 -94
- Partials 18314 18372 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
❌ Gradle check result for 776ebcc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Test Result (1 failure / +1) Flaky Test: #17271 |
❌ Gradle check result for 776ebcc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2bd3e3d
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-3.0 3.0
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-3.0
# Create a new branch
git switch --create backport/backport-17682-to-3.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2bd3e3dcc9a97f8cfd2065b09a125079a2d35f3c
# Push it to GitHub
git push --set-upstream origin backport/backport-17682-to-3.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-3.0 Then, create a pull request where the |
…earch-project#17682) * Removed includeDiscoveryNodes from BaseNodesRequest Signed-off-by: Manik Garg <[email protected]> (cherry picked from commit 2bd3e3d)
…earch-project#17682) * Removed includeDiscoveryNodes from BaseNodesRequest (cherry picked from commit 2bd3e3d) Signed-off-by: Manik Garg <[email protected]>
… (#18047) * Removed includeDiscoveryNodes from BaseNodesRequest (cherry picked from commit 2bd3e3d) Signed-off-by: Manik Garg <[email protected]>
…earch-project#17682) * Removed includeDiscoveryNodes from BaseNodesRequest Signed-off-by: Manik Garg <[email protected]> Signed-off-by: Tanishq Ranjan <[email protected]>
Signed-off-by: Manik Garg <[email protected]>
Signed-off-by: Manik Garg <[email protected]>
Signed-off-by: Manik Garg <[email protected]> (cherry picked from commit d706593) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit d706593) Signed-off-by: Manik Garg <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…earch-project#17682) (opensearch-project#18047) * Removed includeDiscoveryNodes from BaseNodesRequest (cherry picked from commit 2bd3e3d) Signed-off-by: Manik Garg <[email protected]> Signed-off-by: Prudhvi Godithi <[email protected]>
…rch-project#18140) (opensearch-project#18141) (cherry picked from commit d706593) Signed-off-by: Manik Garg <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Prudhvi Godithi <[email protected]>
…earch-project#17682) * Removed includeDiscoveryNodes from BaseNodesRequest Signed-off-by: Manik Garg <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
…earch-project#17682) * Removed includeDiscoveryNodes from BaseNodesRequest Signed-off-by: Manik Garg <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Description
Continuation to #15131, unsetting discovery nodes for every request before sending transport request to individual nodes.
Removed includeDiscoveryNodes field from BaseNodesRequest.
Related Issues
Resolves #17008
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.