Skip to content

Fix remove skip tags for version 6 #17750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rgsriram
Copy link
Contributor

@rgsriram rgsriram commented Apr 1, 2025

Description

Cleaning up skip tags for the test cases related to version 6.x.x

Related Issues

#16574

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Apr 1, 2025

❌ Gradle check result for bf7aedd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

But still remove the version-based skipping.

Signed-off-by: Michael Froh <[email protected]>
Copy link
Contributor

github-actions bot commented Apr 1, 2025

❌ Gradle check result for e19ce78: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 2, 2025

❌ Gradle check result for ecc99ee: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 3, 2025

❌ Gradle check result for ecc99ee: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 7, 2025

❌ Gradle check result for ecc99ee: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 8, 2025

❕ Gradle check result for 1949399: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.45%. Comparing base (8182bb0) to head (1949399).
Report is 35 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17750      +/-   ##
============================================
+ Coverage     72.29%   72.45%   +0.16%     
- Complexity    65900    66035     +135     
============================================
  Files          5350     5350              
  Lines        306185   306208      +23     
  Branches      44373    44375       +2     
============================================
+ Hits         221347   221862     +515     
+ Misses        66670    66225     -445     
+ Partials      18168    18121      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msfroh
Copy link
Contributor

msfroh commented Apr 8, 2025

Overriding the CDO check. I messaged @rgsriram about using git commit -s on future commits. I can confirm that this is his original work, since we discussed it before the changes were made.

@msfroh msfroh merged commit e8b975d into opensearch-project:main Apr 8, 2025
34 of 35 checks passed
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
---------

Signed-off-by: Michael Froh <[email protected]>
Signed-off-by: Sriram Ganesh <[email protected]>
Co-authored-by: Sriram Ganesh <[email protected]>
Co-authored-by: Michael Froh <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
---------

Signed-off-by: Michael Froh <[email protected]>
Signed-off-by: Sriram Ganesh <[email protected]>
Co-authored-by: Sriram Ganesh <[email protected]>
Co-authored-by: Michael Froh <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants