-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix remove skip tags for version 6 #17750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remove skip tags for version 6 #17750
Conversation
❌ Gradle check result for bf7aedd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
rest-api-spec/src/main/resources/rest-api-spec/test/cluster.state/20_filtering.yml
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/test/get/50_with_headers.yml
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/test/indices.shrink/20_source_mapping.yml
Outdated
Show resolved
Hide resolved
But still remove the version-based skipping. Signed-off-by: Michael Froh <[email protected]>
❌ Gradle check result for e19ce78: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
qa/rolling-upgrade/src/test/resources/rest-api-spec/test/old_cluster/20_date_range.yml
Outdated
Show resolved
Hide resolved
❌ Gradle check result for ecc99ee: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ecc99ee: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ecc99ee: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
qa/rolling-upgrade/src/test/resources/rest-api-spec/test/old_cluster/20_date_range.yml
Show resolved
Hide resolved
qa/rolling-upgrade/src/test/resources/rest-api-spec/test/old_cluster/20_date_range.yml
Show resolved
Hide resolved
❕ Gradle check result for 1949399: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17750 +/- ##
============================================
+ Coverage 72.29% 72.45% +0.16%
- Complexity 65900 66035 +135
============================================
Files 5350 5350
Lines 306185 306208 +23
Branches 44373 44375 +2
============================================
+ Hits 221347 221862 +515
+ Misses 66670 66225 -445
+ Partials 18168 18121 -47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overriding the CDO check. I messaged @rgsriram about using |
--------- Signed-off-by: Michael Froh <[email protected]> Signed-off-by: Sriram Ganesh <[email protected]> Co-authored-by: Sriram Ganesh <[email protected]> Co-authored-by: Michael Froh <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
--------- Signed-off-by: Michael Froh <[email protected]> Signed-off-by: Sriram Ganesh <[email protected]> Co-authored-by: Sriram Ganesh <[email protected]> Co-authored-by: Michael Froh <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Description
Cleaning up
skip
tags for the test cases related to version 6.x.xRelated Issues
#16574
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.