Skip to content

Rename search_only_replica settings to search_replica #17857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Apr 9, 2025

Description

Rename search_only_replica settings to search_replica

Related Issues

Resolves ##17845

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Apr 9, 2025

❌ Gradle check result for 747ac76: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 9, 2025

❌ Gradle check result for 0d22144: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 9, 2025

❌ Gradle check result for 0d22144: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 9, 2025

❌ Gradle check result for d7b0f44: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mch2
Copy link
Member Author

mch2 commented Apr 9, 2025

❌ Gradle check result for d7b0f44: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sandeshkr419 Have seen this one pop up a couple of times as flaky - https://build.ci.opensearch.org/job/gradle-check/55966/testReport/junit/org.opensearch.search.aggregations.startree/RangeAggregatorTests/testRangeAggregation
https://build.ci.opensearch.org/job/gradle-check/55857/testReport/junit/org.opensearch.search.aggregations.startree/RangeAggregatorTests/testRangeAggregation/

/ Could you please take a look?

Copy link
Contributor

github-actions bot commented Apr 9, 2025

❌ Gradle check result for d7b0f44: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 9, 2025

✅ Gradle check result for 85e4b00: SUCCESS

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.38%. Comparing base (7b6108b) to head (85e4b00).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17857      +/-   ##
============================================
- Coverage     72.44%   72.38%   -0.07%     
+ Complexity    66483    66454      -29     
============================================
  Files          5409     5409              
  Lines        308282   308282              
  Branches      44759    44759              
============================================
- Hits         223344   223153     -191     
- Misses        66608    66813     +205     
+ Partials      18330    18316      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit 087e473 into opensearch-project:main Apr 9, 2025
31 checks passed
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Apr 15, 2025
…ject#17857)

* Rename search_only_replica settings to search_replica

Signed-off-by: Marc Handalian <[email protected]>

* Fix missed test cases expecting search_only exception messageA

Signed-off-by: Marc Handalian <[email protected]>

* Fix tests not using setting constant

Signed-off-by: Marc Handalian <[email protected]>

---------

Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: Sriram Ganesh <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…ject#17857)

* Rename search_only_replica settings to search_replica

Signed-off-by: Marc Handalian <[email protected]>

* Fix missed test cases expecting search_only exception messageA

Signed-off-by: Marc Handalian <[email protected]>

* Fix tests not using setting constant

Signed-off-by: Marc Handalian <[email protected]>

---------

Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…ject#17857)

* Rename search_only_replica settings to search_replica

Signed-off-by: Marc Handalian <[email protected]>

* Fix missed test cases expecting search_only exception messageA

Signed-off-by: Marc Handalian <[email protected]>

* Fix tests not using setting constant

Signed-off-by: Marc Handalian <[email protected]>

---------

Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants