[Bug-fix] Fix redundant loading of global ordinals #18059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandesh Kumar <[email protected]>
sandeshkr419
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
sandeshkr419
added
skip-changelog
v3.0.0
|
❌ Gradle check result for 7e7ce79: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18059 +/- ##
============================================
+ Coverage 72.47% 72.49% +0.01%
- Complexity 67034 67101 +67
============================================
Files 5478 5473 -5
Lines 310132 310067 -65
Branches 45087 45053 -34
============================================
- Hits 224775 224769 -6
+ Misses 66960 66934 -26
+ Partials 18397 18364 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
expani
reviewed
Apr 24, 2025
...ava/org/opensearch/search/aggregations/bucket/terms/GlobalOrdinalsStringTermsAggregator.java
Show resolved
Hide resolved
expani
reviewed
Apr 24, 2025
...ava/org/opensearch/search/aggregations/bucket/terms/GlobalOrdinalsStringTermsAggregator.java
Show resolved
Hide resolved
expani
approved these changes
Apr 26, 2025
jainankitk
approved these changes
Apr 26, 2025
jainankitk
approved these changes
Apr 26, 2025
andrross
approved these changes
Apr 28, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
Signed-off-by: Sandesh Kumar <[email protected]> (cherry picked from commit 1d998f1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peterzhuamazon
pushed a commit
that referenced
this pull request
Apr 28, 2025
(cherry picked from commit 1d998f1) Signed-off-by: Sandesh Kumar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi
pushed a commit
to prudhvigodithi/OpenSearch
that referenced
this pull request
May 6, 2025
…pensearch-project#18112) (cherry picked from commit 1d998f1) Signed-off-by: Sandesh Kumar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Prudhvi Godithi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loading global ordinals is expensive. So loading up global ordinals only when absolutely required and ensuring that the search request does not loads up global ordinals multiple times.
Related Issues
Resolves #17979
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.