Skip to content

[Backport 3.0] [Star Tree] Support of Boolean Queries in Aggregations (#17941) #18097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025

Conversation

imRishN
Copy link
Member

@imRishN imRishN commented Apr 28, 2025


Description

Backport #17941

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 5f5ef58: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishab Nahata <[email protected]>
Copy link
Contributor

✅ Gradle check result for 8f72ed6: SUCCESS

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 85.05155% with 29 lines in your changes missing coverage. Please review.

Project coverage is 72.57%. Comparing base (e0272e0) to head (8f72ed6).
Report is 1 commits behind head on 3.0.

Files with missing lines Patch % Lines
...tartree/filter/provider/DimensionFilterMapper.java 48.27% 3 Missing and 12 partials ⚠️
...ee/filter/provider/BoolStarTreeFilterProvider.java 89.02% 4 Missing and 5 partials ⚠️
...ch/startree/filter/DimensionFilterMergerUtils.java 94.66% 1 Missing and 3 partials ⚠️
...search/search/startree/filter/DimensionFilter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.0   #18097      +/-   ##
============================================
- Coverage     72.58%   72.57%   -0.01%     
- Complexity    67139    67196      +57     
============================================
  Files          5478     5480       +2     
  Lines        310120   310314     +194     
  Branches      45080    45138      +58     
============================================
+ Hits         225092   225205     +113     
- Misses        66684    66720      +36     
- Partials      18344    18389      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sachinpkale sachinpkale requested a review from linuxpi as a code owner April 28, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants