Skip to content

Document GRPC settings and default values in README #18506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

karenyrx
Copy link
Contributor

@karenyrx karenyrx commented Jun 12, 2025

Description

Document how the GRPC settings should be used and add the missing grpc.netty.max_msg_size setting to the README.
A corresponding PR in the documentation-webste repo will be created later on as well to reflect these changes.

Related Issues

#16787

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@karenyrx
Copy link
Contributor Author

karenyrx commented Jun 12, 2025

Let me know if a changelog entry is required for this. Thanks!

@karenyrx karenyrx marked this pull request as ready for review June 12, 2025 18:57
@karenyrx karenyrx requested a review from a team as a code owner June 12, 2025 18:57
Copy link
Contributor

❌ Gradle check result for 23c2de6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 23c2de6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 23c2de6: SUCCESS

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.79%. Comparing base (4d6f8ba) to head (23c2de6).
Report is 39 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18506      +/-   ##
============================================
+ Coverage     72.67%   72.79%   +0.12%     
- Complexity    67881    67967      +86     
============================================
  Files          5516     5516              
  Lines        312443   312443              
  Branches      45360    45360              
============================================
+ Hits         227067   227451     +384     
+ Misses        66893    66455     -438     
- Partials      18483    18537      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peterzhuamazon
Copy link
Member

Approved but asking @andrross @finnegancarroll to check as well.

Thanks.

@andrross andrross merged commit 7b5ebf2 into opensearch-project:main Jun 16, 2025
79 of 97 checks passed
abhita pushed a commit to abhita/OpenSearch that referenced this pull request Jun 17, 2025
neuenfeldttj added a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants