-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Document GRPC settings and default values in README #18506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Karen Xu <[email protected]>
Let me know if a changelog entry is required for this. Thanks! |
❌ Gradle check result for 23c2de6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 23c2de6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18506 +/- ##
============================================
+ Coverage 72.67% 72.79% +0.12%
- Complexity 67881 67967 +86
============================================
Files 5516 5516
Lines 312443 312443
Branches 45360 45360
============================================
+ Hits 227067 227451 +384
+ Misses 66893 66455 -438
- Partials 18483 18537 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Approved but asking @andrross @finnegancarroll to check as well. Thanks. |
…ct#18506) Signed-off-by: Karen Xu <[email protected]> Co-authored-by: Karen Xu <[email protected]>
…ct#18506) Signed-off-by: Karen Xu <[email protected]> Co-authored-by: Karen Xu <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
…ct#18506) Signed-off-by: Karen Xu <[email protected]> Co-authored-by: Karen Xu <[email protected]>
Description
Document how the GRPC settings should be used and add the missing
grpc.netty.max_msg_size
setting to the README.A corresponding PR in the documentation-webste repo will be created later on as well to reflect these changes.
Related Issues
#16787
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.