Skip to content

Add support for custom index name resolver from cluster plugin #18593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 4, 2025

Conversation

Gagan6164
Copy link
Contributor

@Gagan6164 Gagan6164 commented Jun 24, 2025

Description

Add support for cluster plugins to provide their implementation for Index name expression resolvers as per their needs.

Related Issues

Resolves #18676

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Gagan6164 Gagan6164 requested a review from a team as a code owner June 24, 2025 05:20
Gagan Singh Saini added 4 commits June 24, 2025 10:55
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Signed-off-by: Gagan Singh Saini <[email protected]>
Copy link
Contributor

✅ Gradle check result for 1215cfc: SUCCESS

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.81%. Comparing base (d404f33) to head (2219cc6).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
.../cluster/metadata/IndexNameExpressionResolver.java 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18593      +/-   ##
============================================
+ Coverage     72.76%   72.81%   +0.05%     
- Complexity    68167    68205      +38     
============================================
  Files          5541     5542       +1     
  Lines        313426   313454      +28     
  Branches      45479    45480       +1     
============================================
+ Hits         228062   228255     +193     
+ Misses        66709    66616      -93     
+ Partials      18655    18583      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rishabhmaurya
Copy link
Contributor

@Gagan6164 I'm curious where do we need it? some background will be helpful.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Plugins labels Jul 3, 2025
@Gagan6164
Copy link
Contributor Author

Gagan6164 commented Jul 3, 2025

@Gagan6164 I'm curious where do we need it? some background will be helpful.

@rishabhmaurya Captured the requirement/background details in this issue #18676 . Do let me know if additional details are required.

Signed-off-by: Gagan Singh Saini <[email protected]>
Copy link
Contributor

github-actions bot commented Jul 3, 2025

❌ Gradle check result for d033f96: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gagan Singh Saini <[email protected]>
Copy link
Contributor

github-actions bot commented Jul 3, 2025

❌ Gradle check result for d27cb36: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gagan Singh Saini <[email protected]>
Copy link
Contributor

github-actions bot commented Jul 3, 2025

✅ Gradle check result for 2219cc6: SUCCESS

@gbbafna gbbafna merged commit fbfa626 into opensearch-project:main Jul 4, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support for Custom Index Name resolver from cluster plugin
3 participants