[WLM] Add WLM mode validation for workload group CRUD requests #18652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruai0511
changed the title
ruai0511
force-pushed
the
wlmmode-fix
branch
3 times, most recently
from
145a19b to
4705a32
Compare
|
❌ Gradle check result for 4705a32: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...ns/workload-management/src/main/java/org/opensearch/plugin/wlm/WorkloadManagementPlugin.java
Outdated
Show resolved
Hide resolved
...ns/workload-management/src/main/java/org/opensearch/plugin/wlm/WorkloadManagementPlugin.java
Outdated
Show resolved
Hide resolved
...d-management/src/main/java/org/opensearch/plugin/wlm/rest/RestCreateWorkloadGroupAction.java
Outdated
Show resolved
Hide resolved
...d-management/src/main/java/org/opensearch/plugin/wlm/rest/RestDeleteWorkloadGroupAction.java
Outdated
Show resolved
Hide resolved
...d-management/src/main/java/org/opensearch/plugin/wlm/rest/RestUpdateWorkloadGroupAction.java
Outdated
Show resolved
Hide resolved
ruai0511
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Signed-off-by: Ruirui Zhang <[email protected]>
|
❌ Gradle check result for ab07f3d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...ns/workload-management/src/main/java/org/opensearch/plugin/wlm/WorkloadManagementPlugin.java
Outdated
Show resolved
Hide resolved
plugins/workload-management/src/main/java/org/opensearch/plugin/wlm/WlmModeManager.java
Outdated
Show resolved
Hide resolved
plugins/workload-management/src/main/java/org/opensearch/plugin/wlm/WlmModeManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ruirui Zhang <[email protected]>
|
❌ Gradle check result for 13c3030: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check for the current WLM mode in the prepareRequest() method of the Create, Update, and Delete workload group handlers. If the WLM mode is set to DISABLED, the requests will now fail with error, preventing unintended workload group operations when WLM is turned off.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.