Skip to content

Fix fetchBlob in TransferManager to compute from file cache only if entry is not present #18661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rayshrey
Copy link
Contributor

@rayshrey rayshrey commented Jul 1, 2025

Description

Fix fetchBlob in TransferManager to compute from file cache only if entry is not present

Related Issues

Resolves #18658

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jul 1, 2025

✅ Gradle check result for bf175e7: SUCCESS

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.83%. Comparing base (0874e58) to head (bf175e7).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...arch/index/store/remote/utils/TransferManager.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18661      +/-   ##
============================================
+ Coverage     72.80%   72.83%   +0.03%     
+ Complexity    68437    68433       -4     
============================================
  Files          5563     5563              
  Lines        314174   314172       -2     
  Branches      45554    45555       +1     
============================================
+ Hits         228726   228825      +99     
+ Misses        66871    66817      -54     
+ Partials      18577    18530      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Jul 3, 2025

❌ Gradle check result for c4f8e86: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jul 3, 2025

❌ Gradle check result for 3bc468c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jul 4, 2025

❌ Gradle check result for be3dccc:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shreyansh Ray <[email protected]>
@rayshrey rayshrey force-pushed the transferManagerComputeFix branch from be3dccc to e280fe6 Compare July 4, 2025 05:29
@github-project-automation github-project-automation bot moved this to 👀 In review in Storage Project Board Jul 4, 2025
Copy link
Contributor

github-actions bot commented Jul 4, 2025

❌ Gradle check result for e280fe6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

[BUG] Transfer Manager removes entries from FileCache if CircuitBreaker trips while downloading blob
3 participants