Skip to content

Add Profile Functionality to Fetch Phase #18664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

andrevandeven
Copy link

@andrevandeven andrevandeven commented Jul 1, 2025

Description

Extended existing profile classes to time high level fetch phase components. Operations being counted and timed:

  1. Sorting the collection of document IDs before iteration.
  2. Creating the stored fields visitor.
  3. Building the necessary sub-phase processors.
  4. Time spent getting new leaf readers.
  5. Preparing hit contexts, including the time spent loading stored fields.
  6. Executing each individual sub-phase.
  7. The final assembly and construction of the SearchHit objects.

Related Issues

Resolves #1764

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added distributed framework enhancement Enhancement or improvement to existing feature or request lucene labels Jul 1, 2025
Andre van de Ven added 3 commits July 1, 2025 15:35
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Signed-off-by: Andre van de Ven <[email protected]>
Copy link
Contributor

github-actions bot commented Jul 1, 2025

❌ Gradle check result for 30e991d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Andre van de Ven <[email protected]>
@msfroh
Copy link
Contributor

msfroh commented Jul 1, 2025

Ooh, neat! I'll review this week, but in case I forget, please feel free to @ mention me, @andrevandeven.

Copy link
Contributor

github-actions bot commented Jul 2, 2025

❌ Gradle check result for 82d47ef: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Andre van de Ven <[email protected]>
Copy link
Contributor

github-actions bot commented Jul 2, 2025

❌ Gradle check result for 9c9a819: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jul 3, 2025

❌ Gradle check result for 582046a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request lucene
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fetch phase to search profile
2 participants