Replaced CPU load average logic with AverageTracker classes. Default thresholds modified #18666
+222
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Thresholds modified Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah and
a team
as code owners
…Thresholds modified Signed-off-by: Harsh Kothari <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
|
❌ Gradle check result for 3c4e687: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
… for Regexp queries introduced in OpenSearch 3.0 (opensearch-project#18640) * FIx ~ bug Signed-off-by: Prudhvi Godithi <[email protected]> * Update changelog Signed-off-by: Prudhvi Godithi <[email protected]> --------- Signed-off-by: Prudhvi Godithi <[email protected]>
* Fix bug in replication lag computation. This change fixes a bug with replication lag computation to correctly use epoch reference point with Instant.now() and DateUtils. This change also fixes pruning logic to correctly remove the latest synced to checkpoint from tracking. Previously we would only prune up to the latest. This ensures that when a new checkpoint is eventually received we aren't incorrectly computing lag from the synced-to checkpoint. Signed-off-by: Marc Handalian <[email protected]> * add changelog entry Signed-off-by: Marc Handalian <[email protected]> * Fix flaky test to hardcode time lag between checkpoint arrival. Signed-off-by: Marc Handalian <[email protected]> --------- Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18666 +/- ##
============================================
+ Coverage 72.72% 72.74% +0.02%
- Complexity 68409 68440 +31
============================================
Files 5566 5569 +3
Lines 314292 314369 +77
Branches 45579 45588 +9
============================================
+ Hits 228554 228682 +128
+ Misses 67153 67130 -23
+ Partials 18585 18557 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chaitanya588
reviewed
Jul 3, 2025
server/src/main/java/org/opensearch/index/autoforcemerge/ForceMergeManagerSettings.java
Show resolved
Hide resolved
ajaymovva
reviewed
Jul 3, 2025
server/src/main/java/org/opensearch/index/autoforcemerge/ResourceTrackerProvider.java
Show resolved
Hide resolved
Signed-off-by: Harsh Kothari <[email protected]>
gbbafna
reviewed
Jul 3, 2025
server/src/main/java/org/opensearch/index/autoforcemerge/ResourceTrackerProvider.java
Outdated
Show resolved
Hide resolved
chaitanya588
reviewed
Jul 3, 2025
server/src/main/java/org/opensearch/index/autoforcemerge/AutoForceMergeManager.java
Show resolved
Hide resolved
…s logic Signed-off-by: Harsh Kothari <[email protected]>
|
❌ Gradle check result for 972b1bd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
added 2 commits
July 4, 2025 21:46
…s logic Signed-off-by: Harsh Kothari <[email protected]>
chaitanya588
approved these changes
Jul 4, 2025
ajaymovva
reviewed
Jul 4, 2025
server/src/main/java/org/opensearch/index/autoforcemerge/ResourceTrackerProvider.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for a61045d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Jul 4, 2025
added 3 commits
July 5, 2025 08:26
Signed-off-by: Harsh Kothari <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
|
❌ Gradle check result for 5d0223c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced CPU load average logic with AverageTracker classes.
Default thresholds modified
Relevant JUnits added / modified
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.