-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Move gRPC transitive dependencies to expected version #18672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move gRPC transitive dependencies to expected version #18672
Conversation
@finnegancarroll Do you mind adding the version bump to the changelog? |
❌ Gradle check result for 70e1a6c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
70e1a6c
to
d4d927a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18672 +/- ##
============================================
- Coverage 72.68% 72.61% -0.08%
+ Complexity 68420 68404 -16
============================================
Files 5569 5571 +2
Lines 314467 314710 +243
Branches 45614 45676 +62
============================================
- Hits 228580 228531 -49
- Misses 67347 67605 +258
- Partials 18540 18574 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@finnegancarroll do we need to declare these transitive dependencies explicitly? |
d4d927a
to
017881e
Compare
I believe we enforce explicitly listing all transitive dependencies. I'm not sure exactly where this is enforced but do see |
❌ Gradle check result for 017881e: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 017881e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 017881e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 017881e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 017881e: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 404acd2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 404acd2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 404acd2: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 404acd2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 404acd2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 404acd2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 404acd2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
A couple of dependencies in the gRPC transport plugin expect slightly different transitive dependency versions than what we explicitly force in
build.gradle
.grpc-netty-shaded:1.68.2 expects perfmark-api:0.27.0 but we use 0.26.0.
guava:33.2.1-jre expects failureaccess:1.0.2 but we use 1.0.1.
As core explicitly declares a version for these transitive dependencies gradle does not see a conflict. However when a plugin wants to include
org.opensearch.plugin:transport-grpc:<version>-SNAPSHOT
as a dependency gradle sees both the original expected transitive dependency and the forced version included in the snapshot and cannot immediately resolve this conflict.To avoid requiring plugins to force dependency versions or include a resolution strategy we should match versions exactly.
Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.