-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Approximation Framework] Extending approximation to top-level term queries on numeric fields #18679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I'm waiting on #18530 to get merged before rebasing and refactoring my tests to integrate with the parameterized versions in |
❌ Gradle check result for e8e55c4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ce6db1c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18679 +/- ##
============================================
+ Coverage 72.74% 72.84% +0.10%
- Complexity 68400 68475 +75
============================================
Files 5568 5568
Lines 314401 314429 +28
Branches 45598 45604 +6
============================================
+ Hits 228696 229034 +338
+ Misses 67055 66779 -276
+ Partials 18650 18616 -34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Sawan Srivastava <[email protected]>
Signed-off-by: Sawan Srivastava <[email protected]>
…RangeQuery Signed-off-by: Sawan Srivastava <[email protected]>
Signed-off-by: Sawan Srivastava <[email protected]>
Signed-off-by: Sawan Srivastava <[email protected]>
…on structure Signed-off-by: Sawan Srivastava <[email protected]>
…lderTests Signed-off-by: Sawan Srivastava <[email protected]>
Signed-off-by: Sawan Srivastava <[email protected]>
Signed-off-by: Sawan Srivastava <[email protected]>
Description
Enables approximation in top level term queries on numeric fields by wrapping
termQuery
mappers inNumberFieldMapper
withApproximatePointRangeQuery
instead of Lucene'snewExactQuery
Related Issues
Resolves #18620
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.