Repository navigation
fix(engine): an inlined Array#sort no longer stores Int32 elements as doubles - #58
Conversation
… doubles oven-sh/WebKit#792, appended to the WebKit patch series: with the JIT on, a sort with a comparator doing double arithmetic, inlined by the DFG, could return its Int32 elements out of order as boxed doubles. tests/aot/sort-comparators.mjs guards the ahead-of-time builds, which were not affected.
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7a28eb8b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
oven-sh/WebKit#792, appended to
patches/webkit.patch: with the JIT on, the DFG could inline anArray#sortwhose comparator does double arithmetic and return the Int32 array's elements out of order, as boxed doubles.The
-jitbuilds were affected. The default builds were not:tests/aot/sort-comparators.mjs(new, in the default lists oftests/aot/run.sh) passes on 0.9.4's runtime in all three AOT modes, and now guards them.Runtimes for this commit: the
runtimeworkflow onruntime/wk-792(run 39165966034).