This repository was archived by the owner on Jul 11, 2023. It is now read-only.
k8s: Simplify GetKubernetesEventHandlers() #4171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Delyan Raychev <[email protected]>
draychev
force-pushed
the
simplify-GetKubernetesEventHandlers
branch
from
4ec8fc6 to
d93bd2a
Compare
shashankram
approved these changes
Sep 24, 2021
johnsonshi
approved these changes
Sep 24, 2021
snehachhabria
pushed a commit
to snehachhabria/osm
that referenced
this pull request
Oct 14, 2021
Signed-off-by: Delyan Raychev <[email protected]> Signed-off-by: Sneha Chhabria <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out the first 2 parameters of
GetKubernetesEventHandlers()are no longer used.This PR removes
informerName,providerNameand all places where these are passed toGetKubernetesEventHandlers().