OCPBUGS-59836: Handle services with empty selectors #161
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shirmoran The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shirmoran
force-pushed
the
handle-svc-empty-selector
branch
2 times, most recently
from
5551261 to
bdb60f5
Compare
|
/test commatrix-e2e-tests |
|
@weliang1: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test commatrix-e2e-tests-2of2 |
|
/retest |
shirmoran
force-pushed
the
handle-svc-empty-selector
branch
from
bdb60f5 to
c63cd91
Compare
|
@shirmoran: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Current issue: when the service.Spec.Selector is empty, the labels.SelectorFromSet function return a label that matches all pods. Than, when listing the pods based on the label we check pods which do not match the service. This PR adds a check whether the service's selector is empty. if the selector is empty: - if the service is internal, than skip this service when adding EPS. - else (extrnal service), we will add all of the ports in the EPS to communication matrix. if the selector is not empty, we will continue in manner we have checked open ports up until now. a chart explaining the entire flow of the communication matrix creation is added to the description of the PR.
shirmoran
force-pushed
the
handle-svc-empty-selector
branch
from
c63cd91 to
73acfce
Compare
shirmoran
changed the title
|
@shirmoran: This pull request references Jira Issue OCPBUGS-59836, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@shirmoran: This pull request references Jira Issue OCPBUGS-59836, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@shirmoran: This pull request references Jira Issue OCPBUGS-59836, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Current issue: when the service.Spec.Selector is empty, the labels.SelectorFromSet function return a label that matches all pods. Than, when listing the pods based on the label we check pods which do not match the service.
This issue seems to be the cause of the following bug: OCPBUGS-59836
This PR adds a check whether the service's selector is empty.
if the selector is empty:
if the selector is not empty, we will continue in manner we have checked open ports up until now.
See the chart explaining the entire flow of the communication matrix creation: