Skip to content

Conversation

mvk
Copy link
Contributor

@mvk mvk commented Aug 25, 2025

  • filter code + tests of conversions of junit xml reports
  • filter usage under doc/
  • add lxml (python requirements for Containerfile)

@mvk
Copy link
Contributor Author

mvk commented Aug 26, 2025

@natifridman, @ccardenosa pls review.

@mvk mvk force-pushed the filter-junit2obj branch from 1053c7f to 41e27bb Compare August 26, 2025 17:25
@ccardenosa
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2025
@mvk
Copy link
Contributor Author

mvk commented Aug 27, 2025

/recheck

@mvk
Copy link
Contributor Author

mvk commented Aug 27, 2025

@kononovn , can you pls review/lgtm ?

- filter code + tests of conversions of junit xml reports
- filter usage under `doc`
- python requirements for `Containerfile` (lxml)

Signed-off-by: Maxim Kovgan <[email protected]>
@mvk mvk force-pushed the filter-junit2obj branch from 41e27bb to ab903f7 Compare August 27, 2025 20:53
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2025
@mvk
Copy link
Contributor Author

mvk commented Aug 28, 2025

@ccardenosa please lgtm again.
Thanks!

@ccardenosa
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2025
@mvk
Copy link
Contributor Author

mvk commented Aug 28, 2025

/assign @ccardenosa

@ccardenosa
Copy link
Collaborator

/approve

Copy link

openshift-ci bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccardenosa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c532fd9 into openshift-kni:main Aug 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants