Skip to content

Conversation

shajmakh
Copy link
Member

We want to be able to see the informer mode of the scheduler as a preparation step for having the informer default change according to the kubelet version.
This commit enables reflecting the informer value (default or configured) as part of the status conditions which is less direct than reporting it in spec and is valid.

@openshift-ci openshift-ci bot requested review from ffromani and swatisehgal July 31, 2025 09:51
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2025
@shajmakh shajmakh force-pushed the sched-informer-condition-in-status branch from 1926e77 to 09d76b9 Compare August 7, 2025 18:04
We want to be able to see the informer mode of the scheduler as a
preparation step for having the informer default change according to the
kubelet version.
This commit enables reflecting the informer value (default or
configured) as part of the status conditions which is less direct than
reporting it in spec and is valid.

Signed-off-by: Shereen Haj <[email protected]>
@shajmakh
Copy link
Member Author

issue during cluster setup
/retest

@ffromani
Copy link
Member

/test ci-install-e2e-compact

Copy link
Member

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

there is still something in this PR which gives me bad vibes, the code seems still a bit alien to the surroundings, but I can't see obvious or blocking problems anymore, so let's move forward.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2025
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 39927cd into openshift-kni:main Aug 13, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants