Skip to content

controllers: make sure to watch support resources #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

controllers: make sure to watch support resources #1803

wants to merge 1 commit into from

Conversation

ffromani
Copy link
Member

Add controller watches for the resources required
for network policies and metric support

@openshift-ci openshift-ci bot requested review from shajmakh and swatisehgal August 12, 2025 13:23
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2025
@ffromani
Copy link
Member Author

/retest

@ffromani
Copy link
Member Author

/retest-required

@ffromani
Copy link
Member Author

ffromani commented Sep 2, 2025

/retest

@ffromani
controllers: make sure to watch support resources
87ae6ee 
Add controller watches for the resources required
for network policies and metric support

Signed-off-by: Francesco Romani <[email protected]>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 2, 2025

@ffromani: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e-install-hypershift 87ae6ee link true /test ci-e2e-install-hypershift
ci/prow/ci-install-e2e-compact 87ae6ee link false /test ci-install-e2e-compact
ci/prow/ci-install-e2e 87ae6ee link true /test ci-install-e2e
ci/prow/ci-must-gather-e2e 87ae6ee link true /test ci-must-gather-e2e
ci/prow/ci-e2e 87ae6ee link true /test ci-e2e
ci/prow/ci-e2e-compact 87ae6ee link false /test ci-e2e-compact

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajmakh shajmakh Awaiting requested review from shajmakh

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ffromani