SPLAT-2044 - [vsphere] promote multi-nic to default

[rvanderp3]

Associated PRs:

• SPLAT-2045: [vsphere] promote multi-nic to default installer#9493

[openshift-ci]

Hello @rvanderp3! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[JoelSpeed]

For the most part, the associated PRs you have raised are likely not needed. Enabling the gate in this repo will allow the MAO and CPMS to pick up the gate change using their gate observers. There's nothing I can think of in client-go or library-go that would require vendoring this change for a gate promotion either.

The installer PR is likely needed though

[rvanderp3]

For the most part, the associated PRs you have raised are likely not needed. Enabling the gate in this repo will allow the MAO and CPMS to pick up the gate change using their gate observers. There's nothing I can think of in client-go or library-go that would require vendoring this change for a gate promotion either.

The installer PR is likely needed though

Thanks @JoelSpeed for taking a look. I wasn't sure how that feature gate change would propagate. That certainly simplifies things.

[openshift-ci]

@rvanderp3: This PR was included in a payload test run from openshift/installer#9493
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[openshift-ci]

@rvanderp3: This PR was included in a payload test run from openshift/installer#9493
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[openshift-ci]

@rvanderp3: This PR was included in a payload test run from openshift/installer#9493
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e63e99d0-1091-11f0-815a-95d1230ecb0a-0

[openshift-ci]

@rvanderp3: This PR was included in a payload test run from openshift/installer#9493
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/659390a0-10b5-11f0-8279-b4f2deeb2bab-0

[rvanderp3]

/test verify-feature-promotion

[jcpowermac]

/lgtm

[JoelSpeed]

@rvanderp3 Where are we at in terms of testing this feature? Do we have specific testing or is an "if it installs, it works" kind of feature, and if that's the case, can you explain what jobs we have in place?

[WenXinWei]

/lgtm

[WenXinWei]

/approve

[rvanderp3]

@rvanderp3 Where are we at in terms of testing this feature? Do we have specific testing or is an "if it installs, it works" kind of feature, and if that's the case, can you explain what jobs we have in place?

Hi @JoelSpeed we've been working on two approaches in case we run out of time:

1. Adding additional e2e tests - OCPBUGS-49351: Added vSphere check for max networks machine-api-operator#1327
2. QE is testing(has tested; thanks @WenXinWei !) this as well in the event we need an exception

We did have an excellent pass rate for the tech preview job, but for some reason(must have been me :( ) its not showing up in prow. I'm investigating that.

[rvanderp3]

@rvanderp3 Where are we at in terms of testing this feature? Do we have specific testing or is an "if it installs, it works" kind of feature, and if that's the case, can you explain what jobs we have in place?

Hi @JoelSpeed we've been working on two approaches in case we run out of time:

1. Adding additional e2e tests - [OCPBUGS-49351: Added vSphere check for max networks machine-api-operator#1327](https://github.com/openshift/machine-api-operator/pull/1327)

2. QE is testing(has tested; thanks @WenXinWei !) this as well in the event we need an exception

We did have an excellent pass rate for the tech preview job, but for some reason(must have been me :( ) its not showing up in prow. I'm investigating that.

me--

https://github.com/openshift/release/pull/63351/files#diff-7ce8489656df8d956c50ed7923f223cabe266e2146255f892fd3f980ba664e20R485-R506

getting a fix in now. i swapped the crons eroneously

[rvanderp3]

/assign @JoelSpeed

[JoelSpeed]

Without tests reporting into sippy, we run the risk of not catching regressions in the features we support. As far as I can tell, there are currently no tests for this gate reporting into sippy.

Do you have both tech preview and stable periodics set up that are testing this feature already?

[rvanderp3]

Without tests reporting into sippy, we run the risk of not catching regressions in the features we support. As far as I can tell, there are currently no tests for this gate reporting into sippy.

Do you have both tech preview and stable periodics set up that are testing this feature already?

Correct, that is why we had QE test it last week. I am working on getting the tests reported in to Sippy(https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network-techpreview/1911775910613225472) but until last week, we didnt have the framework merged to run those tests. I'm working on fixing the test preview tests at the moment.

[rvanderp3]

Without tests reporting into sippy, we run the risk of not catching regressions in the features we support. As far as I can tell, there are currently no tests for this gate reporting into sippy.
Do you have both tech preview and stable periodics set up that are testing this feature already?

Correct, that is why we had QE test it last week. I am working on getting the tests reported in to Sippy(https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network-techpreview/1911775910613225472) but until last week, we didnt have the framework merged to run those tests. I'm working on fixing the test preview tests at the moment.

looks like my test is running with CustomNoUpgrade rather than TechPreview. fixing that now.

[rvanderp3]

@JoelSpeed tech preview periodics have been fixed https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network-techpreview. I'm trying to retrieve payload test results but it appears pr-payload-tests.ci.openshift.org may be having issues. Will try another payload run.

[rvanderp3]

/test verify-feature-promotion

[rvanderp3]

/test verify-feature-promotion

[rvanderp3]

/test verify-feature-promotion

[rvanderp3]

/test verify-feature-promotion

[jcpowermac]

/lgtm

[rvanderp3]

/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network

[openshift-ci]

@rvanderp3: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/75680010-35b8-11f0-9f48-0f9c13316b73-0

[rvanderp3]

@rvanderp3: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/75680010-35b8-11f0-9f48-0f9c13316b73-0

this will fail i think due to the installer PR not being merged, will re-run with the installer PR

[openshift-ci]

@rvanderp3: This PR was included in a payload test run from openshift/installer#9493
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/98420110-35c4-11f0-8df4-88c6ccb4e831-0

[openshift-ci]

@JoelSpeed: This PR was included in a payload test run from openshift/installer#9493
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/64c47730-360c-11f0-847e-38b7925135e2-0

[openshift-ci]

@rvanderp3: This PR was included in a payload test run from openshift/installer#9493
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/666593b0-3672-11f0-9dab-85d17a321450-0

[JoelSpeed]

vSphere testing shows success with the gate removed, LGTM

/lgtm
/retest-required

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, JoelSpeed, rvanderp3, WenXinWei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 998cd53 and 2 for PR HEAD be5e7b0 in total

[rvanderp3]

/retest-required

[rvanderp3]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 998cd53 and 2 for PR HEAD be5e7b0 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3fa6799 and 1 for PR HEAD be5e7b0 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3fa6799 and 2 for PR HEAD be5e7b0 in total

[openshift-ci]

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial-techpreview	562ea8a	link	true	/test e2e-aws-serial-techpreview
ci/prow/e2e-aws-serial	562ea8a	link	true	/test e2e-aws-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3fa6799 and 2 for PR HEAD be5e7b0 in total

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202505270944.p0.gf5e205b.assembly.stream.el9.
All builds following this will include this PR.