Skip to content

Conversation

eggfoobar
Copy link
Contributor

added ability to use multiple feature gates on the same value that graduate to different feature sets at different times

drop DualReplica from TechPreview

Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

Hello @eggfoobar! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 15, 2025
@eggfoobar
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2025
@openshift-ci openshift-ci bot requested review from jkyros and JoelSpeed April 15, 2025 06:40
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eggfoobar
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

added ability to use multiple feature gates on the same value that graduate to different feature sets at different times

drop DualReplica from TechPreview

Signed-off-by: ehila <[email protected]>
@eggfoobar eggfoobar force-pushed the feat_support_multienums branch from 9bc6741 to 8071877 Compare April 15, 2025 16:31
@eggfoobar
Copy link
Contributor Author

Closing in favor of #2283

@eggfoobar eggfoobar closed this Apr 15, 2025
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@eggfoobar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crd-schema 8071877 link true /test verify-crd-schema

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant