Skip to content

WIP: Graduate VolumeGroupSnapshots to GA #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsafrane
Copy link
Contributor

Just testing pass rate of the VolumeGroupSnapshots tests.
Do not merge, the feature is not ready!

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 12, 2025
Copy link
Contributor

openshift-ci bot commented May 12, 2025

Hello @jsafrane! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2025
@openshift-ci openshift-ci bot requested review from deads2k and JoelSpeed May 12, 2025 09:15
Copy link
Contributor

openshift-ci bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane jsafrane force-pushed the graduate-group-snapshots branch from b178a6d to a1f03d3 Compare May 12, 2025 10:43
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2025
Copy link
Contributor

openshift-ci bot commented May 15, 2025

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview a1f03d3 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-serial a1f03d3 link true /test e2e-aws-serial
ci/prow/verify-feature-promotion a1f03d3 link true /test verify-feature-promotion
ci/prow/e2e-aws-ovn-hypershift-conformance a1f03d3 link true /test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-aws-ovn a1f03d3 link true /test e2e-aws-ovn
ci/prow/e2e-aws-serial-techpreview-1of2 a1f03d3 link true /test e2e-aws-serial-techpreview-1of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant