OCPEDGE-1945: feat: promote HighlyAvailableArbiter feature to default #2401
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@eggfoobar: This pull request references OCPEDGE-1945 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @eggfoobar! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/S
|
/assign @JoelSpeed Joel, we had originally written a comment that we can not merge this change until we had resolved the tooling issue with having multi feature gates on the same attribute, since you patched this in #2283 would you consider this comment to no longer be relevant? https://github.com/openshift/api/pull/2401/files#diff-a8b6135d50534471326ea7bcd20e0f5eae25353f7788338060f718128a6a0b34L701 |
|
/test verify-feature-promotion I see tests in sippy, so they should appear here too 🤔 |
Fix incoming, there is a topology diff that causes it not to show up. |
openshift-ci
bot
added
size/L
|
/retest-required |
Signed-off-by: ehila <[email protected]>
updated integration tests to reference baremetal to keep inline with Arbiter and DualReplica main platform use Signed-off-by: ehila <[email protected]>
added two node topology support for featuregate test analyzer to match and query sippy for two node test history Signed-off-by: ehila <[email protected]>
eggfoobar
force-pushed
the
promote-feature-arbiter-default
branch
from
4acf014 to
cc8f48a
Compare
|
/test verify-feature-promotion |
|
/lgtm Tests are in place and pass rates are nearly there on the latest verify. I'll tag and hold this, feel free to keep |
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/unhold Unholding, the feature promotion is above 95% and we have re-gained 99% pass rate in sippy. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
1 similar comment
|
/retest-required |
|
/override ci/prow/e2e-aws-ovn-techpreview Known issue in the test here, https://issues.redhat.com/browse/OCPBUGS-59603 |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-techpreview In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/override ci/prow/e2e-aws-ovn-techpreview Based on https://issues.redhat.com/browse/OCPBUGS-59603, the test failure is a known flake |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-techpreview In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-serial-2of2 |
|
/test e2e-upgrade-out-of-change |
|
@eggfoobar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-aws-ovn-techpreview Based on https://issues.redhat.com/browse/OCPBUGS-59603, the test failure is a known flake |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-techpreview In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 6a7223e
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
Promote HighlyAvailableArbiter to the Default featureSet.
HighlyAvailableArbiter allows deploying an OpenShift cluster with 2 master nodes and 1 arbiter node which will be a smaller capacity machine that will run only the required components for HA to be maintained in edge deployments.
Current Pass Rate: Sippy FeatureSet PassRate 100%
Enhancement PR: openshift/enhancements#1674