Skip to content

Add new ImageBuildDegraded status option for MCO #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

Add new ImageBuildDegraded status option for MCO #2439

merged 1 commit into from
Aug 6, 2025

Conversation

umohnani8
Copy link
Contributor

Add a new ImageBuildDegraded status option for the Image Mode workflow in the MCO. This will b used to track image build failures and report it up to the MCP.

This is part of the fix needed for https://issues.redhat.com/browse/MCO-1536

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

Hello @umohnani8! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 6, 2025
@openshift-ci openshift-ci bot requested review from cgwalters and yuqi-zhang August 6, 2025 10:33
yuqi-zhang
yuqi-zhang approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2025
pablintino
pablintino reviewed Aug 6, 2025
View reviewed changes
machineconfiguration/v1/types.go
@@ -636,6 +636,9 @@ const (
// MachineConfigPoolRenderDegraded means the rendered configuration for the pool cannot be generated because of an error
MachineConfigPoolRenderDegraded MachineConfigPoolConditionType = "RenderDegraded"

// MachineConfigPoolImageBuildDegraded means the image build for the pool was not successful
MachineConfigPoolImageBuildDegraded MachineConfigPoolConditionType = "ImageBuildDegraded"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we need to update this comment?

api/machineconfiguration/v1/types.go

Line 647 in 6a7223e

// MachineConfigPoolDegraded is the overall status of the pool based, today, on whether we fail with NodeDegraded or RenderDegraded

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks!

@umohnani8
Add new ImageBuildDegraded status option for MCO
b15c027 
Add a new ImageBuildDegraded status option for the Image
Mode workflow in the MCO. This will b used to track image
build failures and report it up to the MCP.

Signed-off-by: Urvashi <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2025
@dkhater-redhat
Copy link
Contributor

/lgtm

@umohnani8
Copy link
Contributor Author

@JoelSpeed @everettraven PTAL

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2025
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

@umohnani8: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat, JoelSpeed, umohnani8, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 7605f9b into openshift:master Aug 6, 2025
13 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202508062319.p0.g7605f9b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

2 more reviewers

@pablintino pablintino pablintino left review comments

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@JoelSpeed JoelSpeed

@yuqi-zhang yuqi-zhang

@dkhater-redhat dkhater-redhat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@umohnani8 @dkhater-redhat @JoelSpeed @openshift-bot @pablintino @yuqi-zhang